Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: update enums to use SCREAMING_SNAKE_CASE for consistency #10864

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Feb 19, 2025

No description provided.

@hamz2a hamz2a requested a review from a team as a code owner February 19, 2025 14:46
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Feb 19, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.60%. Comparing base (8ebfe52) to head (cd21841).
Report is 2 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10864      +/-   ##
==========================================
- Coverage   82.61%   82.60%   -0.01%     
==========================================
  Files        1084     1084              
  Lines      107442   107442              
  Branches      729      729              
==========================================
- Hits        88759    88757       -2     
- Misses      18641    18643       +2     
  Partials       42       42              
Flag Coverage Δ
editoast 74.42% <ø> (-0.01%) ⬇️
front 90.51% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the motivation behind this change, since in practice it changes nothing?

@hamz2a
Copy link
Contributor Author

hamz2a commented Feb 19, 2025

What is the motivation behind this change, since in practice it changes nothing?

Nothing special, since I did this for the enum in my previous PR, I just wanted the same for these enums too.

@hamz2a hamz2a requested a review from flomonster February 19, 2025 16:02
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@hamz2a hamz2a added this pull request to the merge queue Feb 19, 2025
Merged via the queue into dev with commit 48e3c2d Feb 19, 2025
27 checks passed
@hamz2a hamz2a deleted the hai/editoast-refactor-enum-screaming-snake-case branch February 19, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants