Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: fix resizable space time chart in stdcm debug results #10865

Merged
merged 1 commit into from
Feb 20, 2025
Merged

front: fix resizable space time chart in stdcm debug results #10865

merged 1 commit into from
Feb 20, 2025

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Feb 19, 2025

closes #10767

@clarani clarani requested a review from a team as a code owner February 19, 2025 15:42
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 19, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2025 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.60%. Comparing base (8ebfe52) to head (213174d).
Report is 8 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev   #10865      +/-   ##
==========================================
- Coverage   82.61%   82.60%   -0.01%     
==========================================
  Files        1084     1084              
  Lines      107442   107444       +2     
  Branches      729      729              
==========================================
- Hits        88759    88752       -7     
- Misses      18641    18650       +9     
  Partials       42       42
Flag Coverage Δ
editoast 74.40% <ø> (-0.03%) ⬇️
front 90.51% <100.00%> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani force-pushed the cni/10767-stdcm-debug-horizontal-scroll branch from 5b0c567 to 8f880bd Compare February 19, 2025 17:01
@clarani clarani requested review from kmer2016 and Akctarus February 20, 2025 08:44
@clarani clarani force-pushed the cni/10767-stdcm-debug-horizontal-scroll branch from 8f880bd to 213174d Compare February 20, 2025 15:41
kmer2016
kmer2016 approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@clarani clarani enabled auto-merge February 20, 2025 15:43
@clarani clarani added this pull request to the merge queue Feb 20, 2025
Akctarus
Akctarus approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@Akctarus Akctarus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, lgtm :)

Merged via the queue into dev with commit 6edea6d Feb 20, 2025
27 checks passed
@clarani clarani deleted the cni/10767-stdcm-debug-horizontal-scroll branch February 20, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmer2016 kmer2016 kmer2016 approved these changes

@Akctarus Akctarus Akctarus approved these changes

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Horizontal scrolling in STDCM in debug mode
4 participants
@clarani @codecov-commenter @kmer2016 @Akctarus