Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: add enabled window for stdcm search env table #10866

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

flomonster
Copy link
Contributor

@flomonster flomonster commented Feb 19, 2025

close #10838

@flomonster flomonster requested a review from a team as a code owner February 19, 2025 17:24
@flomonster flomonster marked this pull request as draft February 19, 2025 17:24
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Feb 19, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 86.84211% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.49%. Comparing base (289c4df) to head (abbad7f).
Report is 30 commits behind head on dev.

Files with missing lines Patch % Lines
editoast/src/views/stdcm_search_environment.rs 69.23% 4 Missing ⚠️
editoast/src/client/stdcm_search_env_commands.rs 85.71% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10866      +/-   ##
==========================================
- Coverage   82.49%   82.49%   -0.01%     
==========================================
  Files        1084     1084              
  Lines      107653   107675      +22     
  Branches      740      740              
==========================================
+ Hits        88807    88824      +17     
- Misses      18804    18809       +5     
  Partials       42       42              
Flag Coverage Δ
editoast 74.39% <86.84%> (+<0.01%) ⬆️
front 90.32% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flomonster flomonster force-pushed the fam/add-enabled-windows-stdcm branch from 3cc1d30 to 23f7230 Compare February 20, 2025 11:23
@flomonster flomonster requested a review from Castavo February 20, 2025 11:25
@flomonster flomonster force-pushed the fam/add-enabled-windows-stdcm branch from 23f7230 to daa3b3d Compare February 20, 2025 15:20
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 20, 2025
@flomonster flomonster force-pushed the fam/add-enabled-windows-stdcm branch 2 times, most recently from e071fbe to 10dc7e2 Compare February 21, 2025 09:29
Copy link
Contributor

@Castavo Castavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diesel migration redo
Tested sending several envs and retrieving them ✅
The front behaves correctly ✅
When adding a new env, reloading the front does pull the new env.

@flomonster flomonster marked this pull request as ready for review February 21, 2025 09:58
@flomonster flomonster requested a review from a team as a code owner February 21, 2025 09:58
@flomonster flomonster force-pushed the fam/add-enabled-windows-stdcm branch 2 times, most recently from 50ca4ca to ff02f3b Compare February 21, 2025 15:26
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flomonster flomonster force-pushed the fam/add-enabled-windows-stdcm branch 2 times, most recently from 676498a to 2f298fb Compare February 21, 2025 17:20
@flomonster flomonster force-pushed the fam/add-enabled-windows-stdcm branch from 2f298fb to abbad7f Compare February 24, 2025 16:07
@flomonster flomonster enabled auto-merge February 24, 2025 16:07
@flomonster flomonster disabled auto-merge February 24, 2025 16:07
@flomonster flomonster added this pull request to the merge queue Feb 25, 2025
Merged via the queue into dev with commit 57034a3 Feb 25, 2025
27 checks passed
@flomonster flomonster deleted the fam/add-enabled-windows-stdcm branch February 25, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lmr: time window for possible simulations is incorrect
6 participants