-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: add enabled window for stdcm search env table #10866
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10866 +/- ##
==========================================
- Coverage 82.49% 82.49% -0.01%
==========================================
Files 1084 1084
Lines 107653 107675 +22
Branches 740 740
==========================================
+ Hits 88807 88824 +17
- Misses 18804 18809 +5
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3cc1d30
to
23f7230
Compare
23f7230
to
daa3b3d
Compare
e071fbe
to
10dc7e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diesel migration redo
✅
Tested sending several envs and retrieving them ✅
The front behaves correctly ✅
When adding a new env, reloading the front does pull the new env.
editoast/migrations/2025-02-19-173042_adapt_search_environment_adding_enabled_window/up.sql
Outdated
Show resolved
Hide resolved
editoast/migrations/2025-02-19-173042_adapt_search_environment_adding_enabled_window/up.sql
Show resolved
Hide resolved
50ca4ca
to
ff02f3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
676498a
to
2f298fb
Compare
Signed-off-by: Florian Amsallem <[email protected]>
2f298fb
to
abbad7f
Compare
close #10838