Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: consolidate consecutive fake tracks overtake steps to single stops in stdcm report #10869

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

Synar
Copy link
Contributor

@Synar Synar commented Feb 20, 2025

Close #10566

(If you want to test this PR, you will need an infra with such overtake tracks, feel free to ask me for a private infra.json ^^)

Before :
fake_stops_overtaking_before
After :
fake_stops_overtaking_after

Some notes :

  • we may not want to add a stopFor value, as it only seems to be used for user requested path steps
  • the existing duration computation would not work as steps to be consolidated do not share a position, and our computatio0n for duration is only precise to the minute. However, it's only required at that precision level by all components that use it, so it should be fine
  • this change does not affect the GET/GEV. If we want to modify them, other changes would be required
  • depending on how temporary this change is supposed to be, we may want to add a specific stop type for overtaking and/or a translation, to avoid this ugly mention in the report sheet :

image

@Synar Synar requested a review from a team as a code owner February 20, 2025 11:06
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 20, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 14.28571% with 30 lines in your changes missing coverage. Please review.

Project coverage is 82.46%. Comparing base (975ec76) to head (53d4b00).
Report is 79 commits behind head on dev.

Files with missing lines Patch % Lines
...cations/stdcm/utils/formatSimulationReportSheet.ts 9.09% 30 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10869      +/-   ##
==========================================
- Coverage   82.60%   82.46%   -0.15%     
==========================================
  Files        1084     1084              
  Lines      107448   107646     +198     
  Branches      729      739      +10     
==========================================
+ Hits        88761    88769       +8     
- Misses      18645    18835     +190     
  Partials       42       42              
Flag Coverage Δ
editoast 74.37% <ø> (-0.06%) ⬇️
front 90.29% <14.28%> (-0.23%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.90% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested and everything works well ! We just need to add the translation for the simulation report sheet before merging ✅

@Synar Synar force-pushed the ali/consolidate-overtaking-stops-in-stdcm-report-front branch from 94f17bb to 53d4b00 Compare February 22, 2025 00:16
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, LGTM !

@Synar Synar requested a review from clarani February 24, 2025 10:17
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM ✅

@Synar Synar added this pull request to the merge queue Feb 26, 2025
Merged via the queue into dev with commit a818cef Feb 26, 2025
27 checks passed
@Synar Synar deleted the ali/consolidate-overtaking-stops-in-stdcm-report-front branch February 26, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: stdcm: identify fake service tracks and report takeover stops
4 participants