front: improve OperationalPointWithTimeAndSpeed type safety, drop timestampToHHMMSS() #10876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is modeled after the Temporal proposal: https://tc39.es/proposal-temporal/docs/duration.html#total Signed-off-by: Simon Ser <[email protected]>
Signed-off-by: Simon Ser <[email protected]>
Signed-off-by: Simon Ser <[email protected]>
Improves type safety. Signed-off-by: Simon Ser <[email protected]>
Improves type safety. Signed-off-by: Simon Ser <[email protected]>
This function is buggy: it formats time in UTC instead of using the local timezone. Instead, use dateToHHMMSS(), which is also more type-safe since it takes a Date as input instead of a number of seconds. This requires getting rid of convertDepartureTimeIntoSec() usage as well, which is great because that function performs some getTimezoneOffset() shenanigans (ends up with the wrong offset depending on daylight savings). We still need to stick to numbers instead of Date objects because we interpolate values. Signed-off-by: Simon Ser <[email protected]>
Synar
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Closes #10873