Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: fix gitignore sprites globbing #10889

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Conversation

leovalais
Copy link
Contributor

Otherwise doesn't ignores files such as:

assets/sprites/TVM430/[email protected]

Signed-off-by: Leo Valais [email protected]

Otherwise doesn't ignores files such as:

```
assets/sprites/TVM430/[email protected]
```

Signed-off-by: Leo Valais <[email protected]>
@leovalais leovalais requested a review from a team as a code owner February 20, 2025 19:39
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Feb 20, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.57%. Comparing base (3d28c83) to head (92b89d0).
Report is 3 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10889      +/-   ##
==========================================
- Coverage   82.57%   82.57%   -0.01%     
==========================================
  Files        1084     1084              
  Lines      107404   107404              
  Branches      730      730              
==========================================
- Hits        88686    88684       -2     
- Misses      18676    18678       +2     
  Partials       42       42              
Flag Coverage Δ
editoast 74.38% <ø> (-0.01%) ⬇️
front 90.47% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leovalais leovalais added this pull request to the merge queue Feb 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 21, 2025
@leovalais leovalais added this pull request to the merge queue Feb 21, 2025
Merged via the queue into dev with commit 61ff350 Feb 21, 2025
27 checks passed
@leovalais leovalais deleted the lva/fio-sprites-gitignore branch February 21, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants