editoast: add rustfmt.toml to .gitignore #10890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We prefer using un-merged `use` statements for clarity and ease of review. `rustfmt` has a `nightly` option to do so automatically, but we don't want to ask everyone to use `nightly` rust. Ignoring `rustfmt.toml` allows to define it locally and still benefit from the auto-formatting of `use` statements, without the risk of accidentally committing it. ``` $ cat rustfmt.toml imports_granularity = "item" ``` If one day we want to commit a mandatory `rustfmt.toml`, we can always revert this commit. Signed-off-by: Leo Valais <[email protected]>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10890 +/- ##
==========================================
- Coverage 82.57% 82.57% -0.01%
==========================================
Files 1084 1084
Lines 107404 107404
Branches 730 730
==========================================
- Hits 88686 88684 -2
- Misses 18676 18678 +2
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposition
We prefer using un-merged
usestatements for clarity and ease ofreview.
rustfmthas anightlyoption to do so automatically, butwe don't want to ask everyone to use
nightlyrust.Ignoring
rustfmt.tomlallows to define it locally and still benefitfrom the auto-formatting of
usestatements, without the risk ofaccidentally committing it.
If one day we want to commit a mandatory
rustfmt.toml, we can alwaysrevert this commit.