Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: handle adding destination via map to single path step train #10897

Merged

Conversation

Synar
Copy link
Contributor

@Synar Synar commented Feb 21, 2025

Close #10115 again ^^

@Synar Synar requested a review from a team as a code owner February 21, 2025 13:04
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 21, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.47%. Comparing base (c38d369) to head (cda6a09).
Report is 59 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10897      +/-   ##
==========================================
- Coverage   82.60%   82.47%   -0.14%     
==========================================
  Files        1084     1084              
  Lines      107444   107484      +40     
  Branches      729      739      +10     
==========================================
- Hits        88756    88645     -111     
- Misses      18646    18797     +151     
  Partials       42       42              
Flag Coverage Δ
editoast 74.37% <ø> (-0.04%) ⬇️
front 90.32% <100.00%> (-0.20%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.90% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Synar Synar force-pushed the ali/handle-adding-destination-to-single-path-step-schedule-in-front branch from 3e26b98 to cda6a09 Compare February 21, 2025 13:32
@Synar Synar requested review from clarani and RomainValls February 24, 2025 18:55
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Copy link
Contributor

@RomainValls RomainValls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested 👍

@Synar Synar added this pull request to the merge queue Feb 25, 2025
Merged via the queue into dev with commit a2f89e8 Feb 25, 2025
27 checks passed
@Synar Synar deleted the ali/handle-adding-destination-to-single-path-step-schedule-in-front branch February 25, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Train schedules with one path step handled weirdly
4 participants