Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix number of steps color in import train schedule #10902

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

RomainValls
Copy link
Contributor

close #10898

@RomainValls RomainValls requested a review from a team as a code owner February 21, 2025 15:26
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 21, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.47%. Comparing base (2f1856a) to head (dfc8d0b).
Report is 63 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10902      +/-   ##
==========================================
- Coverage   82.47%   82.47%   -0.01%     
==========================================
  Files        1084     1084              
  Lines      107478   107478              
  Branches      739      739              
==========================================
- Hits        88644    88641       -3     
- Misses      18792    18795       +3     
  Partials       42       42              
Flag Coverage Δ
editoast 74.38% <ø> (-0.01%) ⬇️
front 90.31% <100.00%> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomainValls RomainValls self-assigned this Feb 21, 2025
@RomainValls RomainValls force-pushed the rvs/front-fix-step-nb-color-in-import branch from df6b404 to dfc8d0b Compare February 21, 2025 15:28
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested ✅

@RomainValls RomainValls added this pull request to the merge queue Feb 27, 2025
Merged via the queue into dev with commit 41e761f Feb 27, 2025
27 checks passed
@RomainValls RomainValls deleted the rvs/front-fix-step-nb-color-in-import branch February 27, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

viriato import: trains with no intermediate steps should not have a red dot
3 participants