Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix scroll in help module #10904

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Conversation

RomainValls
Copy link
Contributor

@RomainValls RomainValls requested a review from a team as a code owner February 21, 2025 16:34
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 21, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.60%. Comparing base (05dae8a) to head (7d330c8).
Report is 1 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10904      +/-   ##
==========================================
- Coverage   81.60%   81.60%   -0.01%     
==========================================
  Files        1095     1095              
  Lines      110438   110438              
  Branches      742      742              
==========================================
- Hits        90128    90127       -1     
- Misses      20268    20269       +1     
  Partials       42       42              
Flag Coverage Δ
editoast 72.19% <ø> (-0.01%) ⬇️
front 90.23% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 2.98% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to be discussed with @thibautsailly but with this change if the help module is open, I can't scroll anymore in the stdcm form.

@RomainValls RomainValls self-assigned this Feb 25, 2025
@thibautsailly
Copy link

I can't see the change you're talking about, but you should be able to scroll the form while reading the help content. Scrolling over the help section should not affect the form, and scrolling the form should not affect the help section.

@RomainValls
Copy link
Contributor Author

Tried a different approach, now the help module and the stdcm body can be scrolled independantly.
@thibautsailly since you can't test, you can check this video

Enregistrement.de.l.ecran.2025-02-25.a.15.55.09.mov

should I modify something ?

@SharglutDev
Copy link
Contributor

Tried a different approach, now the help module and the stdcm body can be scrolled independantly. @thibautsailly since you can't test, you can check this video
should I modify something ?

The scroll in the help module seems to be only in the tab block. What if the screen hides the footer of the help module (phone number etc), is it possible to scroll to see it ?

@RomainValls
Copy link
Contributor Author

Tried a different approach, now the help module and the stdcm body can be scrolled independantly. @thibautsailly since you can't test, you can check this video
should I modify something ?

The scroll in the help module seems to be only in the tab block. What if the screen hides the footer of the help module (phone number etc), is it possible to scroll to see it ?

I'm not sure I get your point, but what happens when we scroll more, is that we'll only see the footer, that will hide the above content

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum I think that adding "overflow: auto" in the class stdcm__help-module is enough (you can scroll in the help module with this)

@RomainValls RomainValls force-pushed the rvs/front-fix-help-module-scroll branch from f56c70c to 141ee09 Compare February 27, 2025 09:12
@RomainValls
Copy link
Contributor Author

Hum I think that adding "overflow: auto" in the class stdcm__help-module is enough (you can scroll in the help module with this)

Thanks, it's done :)

@RomainValls RomainValls force-pushed the rvs/front-fix-help-module-scroll branch from 141ee09 to 7d330c8 Compare February 27, 2025 09:16
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@RomainValls RomainValls added this pull request to the merge queue Feb 27, 2025
Merged via the queue into dev with commit 846afec Feb 27, 2025
27 checks passed
@RomainValls RomainValls deleted the rvs/front-fix-help-module-scroll branch February 27, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants