-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: fix scroll in help module #10904
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10904 +/- ##
==========================================
- Coverage 81.60% 81.60% -0.01%
==========================================
Files 1095 1095
Lines 110438 110438
Branches 742 742
==========================================
- Hits 90128 90127 -1
- Misses 20268 20269 +1
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to be discussed with @thibautsailly but with this change if the help module is open, I can't scroll anymore in the stdcm form.
I can't see the change you're talking about, but you should be able to scroll the form while reading the help content. Scrolling over the help section should not affect the form, and scrolling the form should not affect the help section. |
Tried a different approach, now the help module and the stdcm body can be scrolled independantly. Enregistrement.de.l.ecran.2025-02-25.a.15.55.09.movshould I modify something ? |
The scroll in the help module seems to be only in the tab block. What if the screen hides the footer of the help module (phone number etc), is it possible to scroll to see it ? |
I'm not sure I get your point, but what happens when we scroll more, is that we'll only see the footer, that will hide the above content |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum I think that adding "overflow: auto" in the class stdcm__help-module
is enough (you can scroll in the help module with this)
f56c70c
to
141ee09
Compare
Thanks, it's done :) |
Signed-off-by: romainvalls <[email protected]>
141ee09
to
7d330c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
close https://github.com/osrd-project/osrd-confidential/issues/989