Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osrdyne: add k8s/keda authentication ref support #10909

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Conversation

ElysaSrc
Copy link
Member

No description provided.

@ElysaSrc ElysaSrc requested a review from a team as a code owner February 24, 2025 11:45
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.49%. Comparing base (8ebfe52) to head (deb5dd4).
Report is 42 commits behind head on dev.

Files with missing lines Patch % Lines
osrdyne/src/drivers/kubernetes.rs 0.00% 1 Missing ⚠️
osrdyne/src/drivers/kubernetes/keda.rs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10909      +/-   ##
==========================================
- Coverage   82.61%   82.49%   -0.13%     
==========================================
  Files        1084     1084              
  Lines      107442   107653     +211     
  Branches      729      740      +11     
==========================================
+ Hits        88759    88803      +44     
- Misses      18641    18808     +167     
  Partials       42       42              
Flag Coverage Δ
editoast 74.37% <ø> (-0.06%) ⬇️
front 90.32% <ø> (-0.20%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <0.00%> (-0.01%) ⬇️
railjson_generator 87.58% <ø> (ø)
tests 87.90% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Khoyo Khoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise lgtm

@ElysaSrc ElysaSrc enabled auto-merge February 24, 2025 15:04
@ElysaSrc ElysaSrc added this pull request to the merge queue Feb 24, 2025
Merged via the queue into dev with commit 289c4df Feb 24, 2025
27 checks passed
@ElysaSrc ElysaSrc deleted the ev/fix-k8s-secrets branch February 24, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants