Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix type for macro nodes full name #10918

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

louisgreiner
Copy link
Contributor

Close #10433
Close #10390

@louisgreiner louisgreiner requested a review from a team as a code owner February 24, 2025 17:04
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 24, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.53%. Comparing base (b77308a) to head (5134d15).
Report is 37 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10918      +/-   ##
==========================================
+ Coverage   82.49%   82.53%   +0.04%     
==========================================
  Files        1084     1086       +2     
  Lines      107628   107932     +304     
  Branches      740      740              
==========================================
+ Hits        88786    89082     +296     
- Misses      18800    18808       +8     
  Partials       42       42              
Flag Coverage Δ
editoast 74.38% <ø> (-0.01%) ⬇️
front 90.36% <100.00%> (+0.03%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (-0.01%) ⬇️
railjson_generator 87.58% <ø> (ø)
tests 87.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@louisgreiner louisgreiner force-pushed the lgr/fix-macro-nodes-full-name branch 2 times, most recently from 70099e5 to 5116ecb Compare February 25, 2025 09:43
@louisgreiner louisgreiner force-pushed the lgr/fix-macro-nodes-full-name branch from 5116ecb to 5134d15 Compare February 25, 2025 10:35
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you

@louisgreiner louisgreiner added this pull request to the merge queue Feb 26, 2025
Merged via the queue into dev with commit 2f8d06e Feb 26, 2025
27 checks passed
@louisgreiner louisgreiner deleted the lgr/fix-macro-nodes-full-name branch February 26, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nge: full name of OPs recognized in OSRD not displayed nge: nodes have no name
5 participants