front: fix results display when entering a scenario #10963
Merged
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10963 +/- ##
==========================================
- Coverage 81.60% 81.60% -0.01%
==========================================
Files 1095 1095
Lines 110431 110438 +7
Branches 742 742
==========================================
+ Hits 90121 90125 +4
- Misses 20268 20271 +3
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Akctarus
approved these changes
Feb 26, 2025
front/src/modules/simulationResult/components/SpeedSpaceChart/useSpeedSpaceChart.ts
Show resolved
Hide resolved
SharglutDev
approved these changes
Feb 26, 2025
Some getPathProperties conditions were not in the useEffect depths, so changing these values did not update trainSimulation (which is undefined by default when entering a scenario), preventing the simulation results to be displayed Signed-off-by: theocrsb <[email protected]>
theocrsb
force-pushed
the
tce/front/bug/display-simulation-results
branch
from
f5db792 to
25e5ac5
Compare
|
I just added the description to the commit :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10946
Some
getPathPropertiesconditions were not in the useEffect depths, so changing these values did not updatetrainSimulation(which is undefined by default when entering a scenario), preventing the simulation results to be displayed