Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: use openfga for the role management #10984

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

sim51
Copy link
Contributor

@sim51 sim51 commented Feb 28, 2025

Need those PRs:
#10855
#10981
#10901

The work is only done on the last commit

@github-actions github-actions bot added area:front Work on Standard OSRD Interface modules area:editoast Work on Editoast Service labels Feb 28, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.10%. Comparing base (fa84af4) to head (c9c60ad).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10984      +/-   ##
==========================================
+ Coverage   80.62%   81.10%   +0.47%     
==========================================
  Files        1101      801     -300     
  Lines      112368    81000   -31368     
  Branches      747      747              
==========================================
- Hits        90595    65692   -24903     
+ Misses      21730    15265    -6465     
  Partials       43       43              
Flag Coverage Δ
editoast ?
front 89.92% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 2.53% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sim51 sim51 force-pushed the bsi/openfga-editoast-auth-and-role branch 2 times, most recently from 41812ce to 16f248c Compare March 1, 2025 00:46
@leovalais leovalais force-pushed the bsi/openfga-editoast-auth-and-role branch from 16f248c to 7475479 Compare March 4, 2025 16:04
@leovalais leovalais self-assigned this Mar 4, 2025
@github-actions github-actions bot added the area:ci Work on Continous Integration Pipeline Service label Mar 4, 2025
@leovalais leovalais force-pushed the bsi/openfga-editoast-auth-and-role branch 2 times, most recently from 3c4e33e to fdd00a2 Compare March 7, 2025 17:32
@github-actions github-actions bot removed area:front Work on Standard OSRD Interface modules area:ci Work on Continous Integration Pipeline Service labels Mar 7, 2025
@leovalais leovalais force-pushed the bsi/openfga-editoast-auth-and-role branch from fdd00a2 to e9f59d3 Compare March 7, 2025 17:35
Replace the role management by openfga

Signed-off-by: Benoit Simard <[email protected]>

editoast: fga: fixes lint about tuple indexes

cf. rust-lang/rust#60210

Signed-off-by: Leo Valais <[email protected]>

skim Authorizer API

Signed-off-by: Leo Valais <[email protected]>

editoast_authz interface with openfga

Signed-off-by: Leo Valais <[email protected]>

simplify PgAuthDriver

Signed-off-by: Leo Valais <[email protected]>

propagate changes to views

Signed-off-by: Leo Valais <[email protected]>

setup OpenFGA with a different store for each test

Signed-off-by: Leo Valais <[email protected]>

adapt most of the client

Signed-off-by: Leo Valais <[email protected]>

introduce Regulator

Signed-off-by: Leo Valais <[email protected]>

roles CLI

Signed-off-by: Leo Valais <[email protected]>

cleanup vis

Signed-off-by: Leo Valais <[email protected]>

test

Signed-off-by: Leo Valais <[email protected]>

remove associated type BuiltinRole from StorageDriver

Signed-off-by: Leo Valais <[email protected]>

remove BuiltinRoleSet trait

Signed-off-by: Leo Valais <[email protected]>

adapt some group CLI commands

Signed-off-by: Leo Valais <[email protected]>

add group member

Signed-off-by: Leo Valais <[email protected]>

do not query DB in some cases

Signed-off-by: Leo Valais <[email protected]>

exclude group members

Signed-off-by: Leo Valais <[email protected]>
@leovalais leovalais force-pushed the bsi/openfga-editoast-auth-and-role branch from e9f59d3 to 35d6ca3 Compare March 7, 2025 17:49
Signed-off-by: Leo Valais <[email protected]>
Signed-off-by: Leo Valais <[email protected]>
Signed-off-by: Leo Valais <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants