front: simplify and make simulation PDF download test more robust #11027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Ser <[email protected]>
react-pdf will create an anchor element without an href attribute because instance.url is null while the PDF is being generated: https://github.com/diegomura/react-pdf/blob/f89f75c1f132ba19b54847c3ac23efec675f8d0a/packages/renderer/src/dom/PDFDownloadLink.js#L35 This results in a fetch(null) call, downloading the current HTML page. Later, we try to parse the PDF file and fail with: InvalidPDFException: Invalid PDF structure. Signed-off-by: Simon Ser <[email protected]>
This is less fragile and also ensures that clicking results in the expected behavior (a file being downloaded). Signed-off-by: Simon Ser <[email protected]>
Instead, return the final file path in downloadSimulation(). Signed-off-by: Simon Ser <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.