Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix trad no item in timetabletoolbar #11033

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Uriel-Sautron
Copy link
Contributor

When our timetable is empty, we must display No item and not No train. During development of PacedTrainItem, we forgot to delete part of the code

@Uriel-Sautron Uriel-Sautron requested a review from a team as a code owner March 4, 2025 17:05
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Mar 4, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.70%. Comparing base (8afd60f) to head (8ec2543).
Report is 8 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #11033   +/-   ##
=======================================
  Coverage   80.69%   80.70%           
=======================================
  Files        1098     1098           
  Lines      111888   111907   +19     
  Branches      745      745           
=======================================
+ Hits        90289    90315   +26     
+ Misses      21556    21549    -7     
  Partials       43       43           
Flag Coverage Δ
editoast 72.41% <ø> (+0.03%) ⬆️
front 89.93% <100.00%> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 2.53% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SharglutDev
Copy link
Contributor

While paced train is in dev mode, should we keep the No train when switch is off ?

@Uriel-Sautron
Copy link
Contributor Author

Even if the switch is off in the timetable, a train can be considered as an item.
But I understand your questioning.

Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested

@maelysLeratRosso
Copy link

I think we should keep "Aucun train" in the classic mode, if it is not too long to implement, in order not to disturb users

@Uriel-Sautron
Copy link
Contributor Author

Uriel-Sautron commented Mar 5, 2025

Ok we can leave this PR for the end of the paced train development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants