-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: fix trad no item in timetabletoolbar #11033
base: dev
Are you sure you want to change the base?
Conversation
Signed-off-by: Uriel-Sautron <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #11033 +/- ##
=======================================
Coverage 80.69% 80.70%
=======================================
Files 1098 1098
Lines 111888 111907 +19
Branches 745 745
=======================================
+ Hits 90289 90315 +26
+ Misses 21556 21549 -7
Partials 43 43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
While paced train is in dev mode, should we keep the |
Even if the switch is off in the timetable, a train can be considered as an item. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested
I think we should keep "Aucun train" in the classic mode, if it is not too long to implement, in order not to disturb users |
Ok we can leave this PR for the end of the paced train development. |
When our timetable is empty, we must display No item and not No train. During development of PacedTrainItem, we forgot to delete part of the code