Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using valkey for tests #11055

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

flomonster
Copy link
Contributor

No description provided.

@flomonster flomonster requested review from a team as code owners March 6, 2025 16:54
@github-actions github-actions bot added area:editoast Work on Editoast Service area:ci Work on Continous Integration Pipeline Service labels Mar 6, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.62%. Comparing base (28261be) to head (66f4be1).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #11055      +/-   ##
==========================================
- Coverage   80.63%   80.62%   -0.02%     
==========================================
  Files        1101     1101              
  Lines      112360   112360              
  Branches      747      747              
==========================================
- Hits        90602    90586      -16     
- Misses      21715    21731      +16     
  Partials       43       43              
Flag Coverage Δ
editoast 72.15% <100.00%> (-0.05%) ⬇️
front 89.92% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 2.53% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@Khoyo Khoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Although, I'd really love to have some tests of the caching, I don't think we are testing it right now.

Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Khoyo We don't indeed. But for those a mocked redis interface is likely to be enough, so nothing invalidating this change imo.

@Khoyo
Copy link
Contributor

Khoyo commented Mar 6, 2025

Sure, this was a "by the way, that would be real nice to have", not at all a blocker :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ci Work on Continous Integration Pipeline Service area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants