-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using valkey for tests #11055
base: dev
Are you sure you want to change the base?
Stop using valkey for tests #11055
Conversation
Signed-off-by: Florian Amsallem <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #11055 +/- ##
==========================================
- Coverage 80.63% 80.62% -0.02%
==========================================
Files 1101 1101
Lines 112360 112360
Branches 747 747
==========================================
- Hits 90602 90586 -16
- Misses 21715 21731 +16
Partials 43 43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Although, I'd really love to have some tests of the caching, I don't think we are testing it right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Khoyo We don't indeed. But for those a mocked redis interface is likely to be enough, so nothing invalidating this change imo.
Sure, this was a "by the way, that would be real nice to have", not at all a blocker :) |
No description provided.