Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: move 'simulation_response' one module up #11059

Merged

Conversation

woshilapin
Copy link
Contributor

Proposition to move some code around to avoid visibility shenanigans.

@woshilapin woshilapin requested a review from younesschrifi March 7, 2025 09:33
@woshilapin woshilapin requested a review from a team as a code owner March 7, 2025 09:33
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Mar 7, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.11%. Comparing base (014c70f) to head (4682b73).
Report is 1 commits behind head on yci/add-simulation-paced-endpoint.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                          Coverage Diff                           @@
##           yci/add-simulation-paced-endpoint   #11059       +/-   ##
======================================================================
+ Coverage                              22.94%   81.11%   +58.17%     
======================================================================
  Files                                     85      801      +716     
  Lines                                  10671    81097    +70426     
  Branches                                   0      798      +798     
======================================================================
+ Hits                                    2448    65781    +63333     
- Misses                                  8223    15273     +7050     
- Partials                                   0       43       +43     
Flag Coverage Δ
front 89.92% <ø> (?)
gateway 2.18% <ø> (ø)
osrdyne 2.53% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@younesschrifi younesschrifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! :)

@younesschrifi younesschrifi force-pushed the yci/add-simulation-paced-endpoint branch from 956a5d7 to 2a78d08 Compare March 7, 2025 10:08
@younesschrifi younesschrifi requested a review from a team as a code owner March 7, 2025 10:08
@younesschrifi younesschrifi force-pushed the yci/add-simulation-paced-endpoint branch 2 times, most recently from 161b369 to 014c70f Compare March 7, 2025 10:11
@woshilapin woshilapin force-pushed the wsl/move-simulation-response branch from f1db9f1 to 4682b73 Compare March 7, 2025 10:14
@woshilapin woshilapin merged commit 4682b73 into yci/add-simulation-paced-endpoint Mar 7, 2025
17 checks passed
@woshilapin woshilapin deleted the wsl/move-simulation-response branch March 7, 2025 10:21
@leovalais
Copy link
Contributor

We had a call yesterday (🤔 ?) about the module tree being wrong, we planned to put everything under views::timetable and de-correlate the module tree from the the url path hierarchy. Wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants