-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: move 'simulation_response' one module up #11059
editoast: move 'simulation_response' one module up #11059
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## yci/add-simulation-paced-endpoint #11059 +/- ##
======================================================================
+ Coverage 22.94% 81.11% +58.17%
======================================================================
Files 85 801 +716
Lines 10671 81097 +70426
Branches 0 798 +798
======================================================================
+ Hits 2448 65781 +63333
- Misses 8223 15273 +7050
- Partials 0 43 +43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! :)
956a5d7
to
2a78d08
Compare
161b369
to
014c70f
Compare
Signed-off-by: Jean SIMARD <[email protected]>
f1db9f1
to
4682b73
Compare
4682b73
into
yci/add-simulation-paced-endpoint
We had a call yesterday (🤔 ?) about the module tree being wrong, we planned to put everything under |
Proposition to move some code around to avoid visibility shenanigans.