Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: add comment explaining #[allow(dead_code)] usage #11066

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Mar 7, 2025

No description provided.

@hamz2a hamz2a requested a review from a team as a code owner March 7, 2025 15:44
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Mar 7, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.62%. Comparing base (007883a) to head (d51b561).
Report is 5 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #11066   +/-   ##
=======================================
  Coverage   80.62%   80.62%           
=======================================
  Files        1101     1101           
  Lines      112366   112372    +6     
  Branches      747      747           
=======================================
+ Hits        90590    90595    +5     
- Misses      21733    21734    +1     
  Partials       43       43           
Flag Coverage Δ
editoast 72.18% <ø> (+<0.01%) ⬆️
front 89.92% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 2.53% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hamz2a hamz2a force-pushed the hai/add-comment-allow-dead-code branch from 177233d to d51b561 Compare March 7, 2025 15:46
@hamz2a hamz2a self-assigned this Mar 7, 2025
@hamz2a hamz2a enabled auto-merge March 7, 2025 15:47
@hamz2a hamz2a disabled auto-merge March 7, 2025 16:09
@hamz2a hamz2a enabled auto-merge March 7, 2025 16:09
@hamz2a hamz2a added this pull request to the merge queue Mar 7, 2025
Merged via the queue into dev with commit fa84af4 Mar 7, 2025
27 checks passed
@hamz2a hamz2a deleted the hai/add-comment-allow-dead-code branch March 7, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants