Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add electrification constraint to pathfinding #1931

Merged
merged 3 commits into from
Sep 26, 2022
Merged

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Sep 20, 2022

No description provided.

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #1931 (16ef192) into dev (cec0aad) will increase coverage by 0.08%.
The diff coverage is 94.44%.

@@             Coverage Diff              @@
##                dev    #1931      +/-   ##
============================================
+ Coverage     80.00%   80.08%   +0.08%     
- Complexity     1618     1637      +19     
============================================
  Files           258      261       +3     
  Lines          8406     8451      +45     
  Branches        933      941       +8     
============================================
+ Hits           6725     6768      +43     
  Misses         1288     1288              
- Partials        393      395       +2     
Flag Coverage Δ
core 80.78% <94.44%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...thfinding/constraints/LoadingGaugeConstraints.java 100.00% <ø> (ø)
...cf/osrd/railjson/parser/RJSRollingStockParser.java 19.64% <ø> (ø)
.../railjson/schema/rollingstock/RJSRollingStock.java 100.00% <ø> (ø)
...tion/tracks/undirected/UndirectedInfraBuilder.java 87.02% <90.90%> (+0.18%) ⬆️
...inding/constraints/ElectrificationConstraints.java 91.66% <91.66%> (ø)
...srd/api/pathfinding/PathfindingRoutesEndpoint.java 84.61% <100.00%> (+0.40%) ⬆️
...pi/pathfinding/constraints/ConstraintCombiner.java 100.00% <100.00%> (ø)
...implementation/tracks/directed/TrackRangeView.java 89.61% <100.00%> (+0.13%) ⬆️
...ementation/tracks/undirected/SwitchBranchImpl.java 82.35% <100.00%> (+1.10%) ⬆️
...ementation/tracks/undirected/TrackSectionImpl.java 100.00% <100.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can bump RAILJSON_ROLLING_STOCK_VERSION

@eckter eckter force-pushed the ech/electric-pathfinding branch 7 times, most recently from fe25fd9 to 9f8d9cc Compare September 20, 2022 14:53
@eckter eckter force-pushed the ech/electric-pathfinding branch from 9f8d9cc to 04c57db Compare September 26, 2022 08:22
@eckter eckter force-pushed the ech/electric-pathfinding branch from 04c57db to 16ef192 Compare September 26, 2022 08:26
@eckter eckter requested a review from flomonster September 26, 2022 08:38
@eckter eckter merged commit d7dfd80 into dev Sep 26, 2022
@eckter eckter deleted the ech/electric-pathfinding branch September 26, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check & Adapt Rolling Stock model Adapt pathfinding to take into account electrification
3 participants