-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdcm: intermediate step of the rework (train does not slow down) #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdd0fff
to
a7317cc
Compare
84a4b10
to
dcc8bb0
Compare
dcc8bb0
to
d89ee05
Compare
Codecov Report
@@ Coverage Diff @@
## dev #2025 +/- ##
============================================
+ Coverage 80.15% 80.20% +0.05%
+ Complexity 1631 1627 -4
============================================
Files 261 263 +2
Lines 8354 8256 -98
Branches 941 919 -22
============================================
- Hits 6696 6622 -74
+ Misses 1261 1250 -11
+ Partials 397 384 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
flomonster
reviewed
Oct 6, 2022
core/src/main/java/fr/sncf/osrd/api/stdcm/STDCMPathfinding.java
Outdated
Show resolved
Hide resolved
72c6dc8
to
de8e53d
Compare
multun
reviewed
Oct 6, 2022
This was
linked to
issues
Oct 7, 2022
Closed
multun
reviewed
Oct 10, 2022
core/src/main/java/fr/sncf/osrd/api/pathfinding/RemainingDistanceEstimator.java
Outdated
Show resolved
Hide resolved
flomonster
previously approved these changes
Oct 10, 2022
9e7a0d5
to
abb013e
Compare
multun
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this version we only consider paths where the train goes at full speed, this is not a complete solution to the problem as some paths need delays to be added. We can still find a different (physical) path to avoid occupied tracks.
This scales quite well and doesn't take too much time: on my laptop, an STDCM request for Quiberon - Rennes takes about 100ms, and Brest - Monaco takes about 10 seconds.