editor: allows user to select infra #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes #1986. Details: - Adds a button in the right of the map that opens a modal where the user can select which infra to edit - Also removes viewport data from URLs in editor, since they caused more trouble than they solved issues
|
When I have a selection and I switch to an other infrastructure, the selection is still there with the data of the previous infra |
This commit is related to #1986. It fixes an issue raised by @sim51 in a comment to PR #2069: > When I have a selection and I switch to an other infrastructure, the selection is still there with the data of the previous infra Details: - Groups activeTool and toolState in a single useState call in Editor.tsx internal logic, to prevent some invalid app state - Adds a new `reset` editor action to reset editor state (except for schema, that never changed for now) - Flushes editor and tool state (and active tool, actually) when the infra changes
sim51
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit closes #1986.
Details: