Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: rebase from a fresh new CRA app #2101

Merged
merged 7 commits into from
Oct 17, 2022
Merged

front: rebase from a fresh new CRA app #2101

merged 7 commits into from
Oct 17, 2022

Conversation

sim51
Copy link
Contributor

@sim51 sim51 commented Oct 13, 2022

Fix ticket #1985

Main work is in the package.json and .eslintrc files.

Why I did :

  • using depcheck to see all dependencies that are not used and delete them
  • Change dependencies from the one given by the new CRA app
  • Removing the "service worker" that has been created by the old CRA and adding the reportWebVitals
  • Provide the history to react-router-dom
  • Removing task "prettier" (not needed anymore, code has been already modified) and prettier-eslint-cli is using a higher version of eslint than CRA, so it create a conflict
  • Removing task "jsdoc" which was broken (I tried to fix it, but without success due to an issue with better-doc)
  • Fixing in the code some linter & prettier issue
  • Change the esling configuration so it works with the one provided by CRA (lost airbnb configuration ...)

@sim51 sim51 requested a review from a team October 13, 2022 14:59
@alexandredamiron alexandredamiron merged commit 2c7ea78 into dev Oct 17, 2022
@alexandredamiron alexandredamiron deleted the bsi/new-cra branch October 17, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants