-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: fix: diesel max params on big infra #2334
Conversation
TODO:
|
Codecov Report
@@ Coverage Diff @@
## dev #2334 +/- ##
============================================
- Coverage 80.15% 79.42% -0.74%
- Complexity 1650 1742 +92
============================================
Files 237 284 +47
Lines 7443 7942 +499
Branches 931 976 +45
============================================
+ Hits 5966 6308 +342
- Misses 1143 1279 +136
- Partials 334 355 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
1f22033
to
ea818a0
Compare
About the refactor: Why not a generic function? Mostly because diesel goes insane when you try to write it. If someone is able too, please do. Why not raw SQL? Because AFAIK we don't have a good way to escape SQL in diesel (basically we must call the unsafe fn Codecov is complaining, but does it really make sense to move the test into the macro or duplicate it 11 times ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR!
ea818a0
to
68f41e3
Compare
68f41e3
to
769131b
Compare
Diesel only accepts 65535 parameters per query, so we need to chunk our insertions when importing big infras. Fixes #2328.
769131b
to
ede0ae3
Compare
Diesel only accepts 65535 parameters per query, so we need to chunk our insertions when importing big infras.
Fixes #2328.
Fixes #2301.