Lots of little improvements & bugfixes #2425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nicolaswurtz
commented
Nov 25, 2022
nicolaswurtz
commented
- removed darkmode on simulation (causing artefacts, to be refactored with SCSS refacto)
- removed Timetable in simulation & STDCM (became useless with new DriverTrainSchedule)
- corrected errors on DriverTrainSchedule
- some css fixes
- corrected bug on adding via by clicking on map
- added DriverTrainSchedule for STDCM result
…ywhere, remove errors on DriverTrainSchedule, css fixes
anisometropie
requested changes
Nov 25, 2022
front/src/applications/osrd/components/DriverTrainSchedule/DriverTrainScheduleModal.js
Outdated
Show resolved
Hide resolved
anisometropie
requested changes
Nov 25, 2022
front/src/applications/osrd/views/OSRDSimulation/DriverTrainSchedule.js
Outdated
Show resolved
Hide resolved
front/src/applications/osrd/views/OSRDSimulation/DriverTrainSchedule.js
Outdated
Show resolved
Hide resolved
anisometropie
approved these changes
Nov 25, 2022
flomonster
pushed a commit
that referenced
this pull request
Nov 25, 2022
* front: bugfixes: remove darkmode on simulation, remove Timetable everywhere, remove errors on DriverTrainSchedule, css fixes * front: adding new drivertrainschedule to stdcm * front: corrected bug on adding via on map * front: drivertrainschedule: create function for get mass with one decimal * front: drivertrainschedule: tests simplification * front: common: updated ModalSNCF with hooks & null children possibility Co-authored-by: Nicolas Wurtz <[email protected]>
alexandredamiron
pushed a commit
that referenced
this pull request
Jan 17, 2023
* front: bugfixes: remove darkmode on simulation, remove Timetable everywhere, remove errors on DriverTrainSchedule, css fixes * front: adding new drivertrainschedule to stdcm * front: corrected bug on adding via on map * front: drivertrainschedule: create function for get mass with one decimal * front: drivertrainschedule: tests simplification * front: common: updated ModalSNCF with hooks & null children possibility Co-authored-by: Nicolas Wurtz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.