Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast : add endpoint to retrieve objects data #2485

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

younesschrifi
Copy link
Contributor

@younesschrifi younesschrifi commented Dec 3, 2022

Close #2475

@codecov
Copy link

codecov bot commented Dec 3, 2022

Codecov Report

Merging #2485 (0f66aa7) into dev (1337703) will increase coverage by 42.42%.
The diff coverage is 67.74%.

❗ Current head 0f66aa7 differs from pull request most recent head 46d2137. Consider uploading reports for the commit 46d2137 to get more accurate results

@@              Coverage Diff              @@
##                dev    #2485       +/-   ##
=============================================
+ Coverage     37.61%   80.04%   +42.42%     
  Complexity     1661     1661               
=============================================
  Files           551      238      -313     
  Lines         16808     7455     -9353     
  Branches       2355      940     -1415     
=============================================
- Hits           6323     5967      -356     
+ Misses        10115     1149     -8966     
+ Partials        370      339       -31     
Flag Coverage Δ
editoast 70.19% <67.74%> (+0.24%) ⬆️
front ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
editoast/src/schema/mod.rs 73.21% <0.00%> (-22.14%) ⬇️
editoast/src/views/infra/objects.rs 82.92% <82.92%> (ø)
editoast/src/views/infra/mod.rs 85.98% <100.00%> (+0.13%) ⬆️
editoast/src/views/params.rs 80.95% <100.00%> (+9.52%) ⬆️
editoast/src/generated_data/utils.rs 78.94% <0.00%> (-5.27%) ⬇️
.../common/BootstrapSNCF/TableSNCF/TableHeaderSNCF.js
front/src/common/Loader.js
front/src/common/api/emptyApi.ts
front/src/common/CenterLoader/CenterLoader.js
...tions/editor/components/LinearMetadata/dataviz.tsx
... and 310 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@younesschrifi younesschrifi force-pushed the yci/retrieve-objects-railjson branch 5 times, most recently from 6d7d434 to 4dc76de Compare December 7, 2022 11:24
@flomonster flomonster changed the title editoast : add endpoint to openapi editoast : add endpoint to retrieve objects data Dec 7, 2022
@younesschrifi younesschrifi force-pushed the yci/retrieve-objects-railjson branch 2 times, most recently from a25db06 to 041d585 Compare December 8, 2022 11:19
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there. You should add some tests.

@younesschrifi younesschrifi force-pushed the yci/retrieve-objects-railjson branch 10 times, most recently from bd2189b to c090ccf Compare December 12, 2022 10:17
@younesschrifi younesschrifi marked this pull request as ready for review December 12, 2022 10:17
@younesschrifi younesschrifi force-pushed the yci/retrieve-objects-railjson branch 3 times, most recently from cb91025 to 2dc7b2a Compare December 12, 2022 12:32
@younesschrifi younesschrifi force-pushed the yci/retrieve-objects-railjson branch from 2dc7b2a to 46d2137 Compare December 12, 2022 12:36
@younesschrifi younesschrifi merged commit fb54fdd into dev Dec 12, 2022
@younesschrifi younesschrifi deleted the yci/retrieve-objects-railjson branch December 12, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an endpoint to retrieve objects railjson
2 participants