Nwz/crud infra #2561
Merged
Nwz/crud infra #2561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #2561 +/- ##
============================================
- Coverage 38.02% 37.72% -0.30%
Complexity 1666 1666
============================================
Files 554 560 +6
Lines 16977 17112 +135
Branches 2359 2375 +16
============================================
Hits 6455 6455
- Misses 10152 10287 +135
Partials 370 370
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nicolaswurtz
force-pushed
the
nwz/crud-infra
branch
from
cca4adc to
01d9be4
Compare
3 tasks
nicolaswurtz
force-pushed
the
nwz/crud-infra
branch
from
01d9be4 to
cecc4b3
Compare
Math-R
previously approved these changes
Dec 13, 2022
Math-R
previously approved these changes
Dec 13, 2022
…to correct modal behaviour before
nicolaswurtz
force-pushed
the
nwz/crud-infra
branch
from
580479b to
a765089
Compare
alexandredamiron
approved these changes
Dec 15, 2022
Akctarus
pushed a commit
that referenced
this pull request
Dec 19, 2022
* front: crudInfra: set infraselector as single source of truth for api * front: crudInfra: continue isolation of component * front: crudInfra: added locked state * front: crudInfra: getInfra inside infraselectormodal * front: crudInfra: some cosmetics changes, icons, harmonize styles * front: crudInfra: Added lock/unlock & cosmetics changes * front: crudInfra: repair side damage on timetable selector * front: crudInfra: export railjson ok * front: crudInfra: delete ok * front: crudInfra: done ! * front: have to desactivate resizing of map in simulation, we'll have to correct modal behaviour before * front: crudInfra: removed setMustRefresh because it was ugly
alexandredamiron
pushed a commit
that referenced
this pull request
Jan 9, 2023
* front: crudInfra: set infraselector as single source of truth for api * front: crudInfra: continue isolation of component * front: crudInfra: added locked state * front: crudInfra: getInfra inside infraselectormodal * front: crudInfra: some cosmetics changes, icons, harmonize styles * front: crudInfra: Added lock/unlock & cosmetics changes * front: crudInfra: repair side damage on timetable selector * front: crudInfra: export railjson ok * front: crudInfra: delete ok * front: crudInfra: done ! * front: have to desactivate resizing of map in simulation, we'll have to correct modal behaviour before * front: crudInfra: removed setMustRefresh because it was ugly
alexandredamiron
pushed a commit
that referenced
this pull request
Jan 17, 2023
* front: crudInfra: set infraselector as single source of truth for api * front: crudInfra: continue isolation of component * front: crudInfra: added locked state * front: crudInfra: getInfra inside infraselectormodal * front: crudInfra: some cosmetics changes, icons, harmonize styles * front: crudInfra: Added lock/unlock & cosmetics changes * front: crudInfra: repair side damage on timetable selector * front: crudInfra: export railjson ok * front: crudInfra: delete ok * front: crudInfra: done ! * front: have to desactivate resizing of map in simulation, we'll have to correct modal behaviour before * front: crudInfra: removed setMustRefresh because it was ugly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ModalSNCFbehaviour was incorrect in simulation's map, because of resizing system. I've desactivated it yet (code remains in comments), we'll have to find a solution (eg. changeModalSNCFcomponent & harmonize modals trough the application)