Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration to new route schema (railjson v3.1.0 🎉) #2576

Merged
merged 8 commits into from
Jan 9, 2023
Merged

Migration to new route schema (railjson v3.1.0 🎉) #2576

merged 8 commits into from
Jan 9, 2023

Conversation

flomonster
Copy link
Contributor

@flomonster flomonster commented Dec 12, 2022 •
edited
Loading

close #1999

This PR contains:

  • The migration to the new route format (railjson v3.1.0)
  • The adaptation of services (editoast, core, api, tests, infra_generator)
  • Editoast has a better and more flexible way to generate infra errors (adding context to error generators)
  • A small fix on STDCM (spotted with the new new way to generate random path in integration tests)
  • Adapt setup dummy API command

@flomonster flomonster requested a review from a team December 12, 2022 17:00
@flomonster flomonster marked this pull request as draft December 12, 2022 17:00
@codecov
Copy link

codecov bot commented Dec 12, 2022 •
edited
Loading

Codecov Report

Merging #2576 (5b9a580) into dev (54acdf5) will increase coverage by 0.01%.
The diff coverage is 92.33%.

@@             Coverage Diff              @@
##                dev    #2576      +/-   ##
============================================
+ Coverage     37.91%   37.92%   +0.01%     
+ Complexity     1679     1678       -1     
============================================
  Files           581      581              
  Lines         17818    17839      +21     
  Branches       2452     2461       +9     
============================================
+ Hits           6756     6766      +10     
  Misses        10677    10677              
- Partials        385      396      +11
Flag Coverage Δ
core 83.68% <85.45%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../fr/sncf/osrd/infra/errors/DiscontinuousRoute.java 75.00% <0.00%> (+75.00%) ⬆️
editoast/src/chartos/bounding_box.rs 17.59% <0.00%> (ø)
editoast/src/generated_data/mod.rs 94.23% <ø> (ø)
editoast/src/infra.rs 66.66% <ø> (ø)
editoast/src/views/infra/mod.rs 95.89% <ø> (ø)
editoast/src/generated_data/error/signals.rs 81.81% <66.66%> (ø)
...implementation/tracks/directed/TrackRangeView.java 89.28% <71.42%> (-1.63%) ⬇️
...mentation/reservation/ReservationInfraBuilder.java 86.84% <87.50%> (-6.69%) ⬇️
editoast/src/generated_data/error/switches.rs 90.90% <90.47%> (ø)
editoast/src/generated_data/error/routes.rs 94.17% <93.67%> (ø)
... and 32 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@flomonster flomonster force-pushed the fam/new-routes branch 5 times, most recently from 9947451 to 5bc9255 Compare December 21, 2022 11:47
@flomonster flomonster force-pushed the fam/new-routes branch 3 times, most recently from e91bd99 to bcc540b Compare December 30, 2022 17:56
@flomonster flomonster force-pushed the fam/new-routes branch 6 times, most recently from 0ab22f4 to 4560914 Compare January 4, 2023 23:53
@flomonster flomonster marked this pull request as ready for review January 4, 2023 23:53
@flomonster flomonster requested review from a team as code owners January 4, 2023 23:53
@flomonster flomonster force-pushed the fam/new-routes branch 4 times, most recently from 990392c to ca742a5 Compare January 5, 2023 17:34
@flomonster flomonster changed the title api: adapt route schema for railjson v3.1.0 Migration to new route schema (railjson v3.1.0 🎉) Jan 5, 2023
@flomonster flomonster force-pushed the fam/new-routes branch 2 times, most recently from 15f31fd to 92707cf Compare January 6, 2023 13:35
eckter
eckter reviewed Jan 6, 2023
View reviewed changes
Copy link
Contributor

@eckter eckter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review the rust parts. This is pretty nice, good job

eckter
eckter previously approved these changes Jan 6, 2023
View reviewed changes
@flomonster flomonster force-pushed the fam/new-routes branch 3 times, most recently from 8981f30 to 17cfdf8 Compare January 8, 2023 23:37
multun
multun previously approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@multun multun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what a saga!

Tguisnet
Tguisnet requested changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@Tguisnet Tguisnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent PR.

@flomonster flomonster requested a review from Tguisnet January 9, 2023 16:21
@flomonster flomonster merged commit 9b45471 into dev Jan 9, 2023
@flomonster flomonster deleted the fam/new-routes branch January 9, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@younesschrifi younesschrifi younesschrifi left review comments

@Tguisnet Tguisnet Tguisnet approved these changes

@eckter eckter eckter left review comments

@multun multun multun left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change route format
5 participants
@flomonster @eckter @multun @Tguisnet @younesschrifi