Front: Adn/add grid margin #2596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osrd into adn/addGridMargin
Codecov Report
@@ Coverage Diff @@
## dev #2596 +/- ##
============================================
- Coverage 37.97% 37.52% -0.45%
Complexity 1660 1660
============================================
Files 554 563 +9
Lines 16942 17158 +216
Branches 2355 2379 +24
============================================
+ Hits 6434 6439 +5
- Misses 10137 10348 +211
Partials 371 371
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nicolaswurtz
suggested changes
Dec 15, 2022
front/src/applications/osrd/components/Simulation/Allowances/StandardAllowanceDefault.js
Outdated
Show resolved
Hide resolved
front/src/applications/osrd/components/Simulation/Allowances/StandardAllowanceDefault.js
Outdated
Show resolved
Hide resolved
nicolaswurtz
approved these changes
Dec 15, 2022
Akctarus
pushed a commit
that referenced
this pull request
Dec 19, 2022
* prepare isolation * first Isolation Effort * Standard Allowance Isolation * Advanced Stdcm Setup * set grid Margin After Before in stdcm Context * prepare isolation * first Isolation Effort * Standard Allowance Isolation * Advanced Stdcm Setup * set grid Margin After Before in stdcm Context * Fill with persisted Values * eslint and exhaustive deps * Correct optim error * après trad * conditionnal layout
alexandredamiron
added a commit
that referenced
this pull request
Jan 9, 2023
* prepare isolation * first Isolation Effort * Standard Allowance Isolation * Advanced Stdcm Setup * set grid Margin After Before in stdcm Context * prepare isolation * first Isolation Effort * Standard Allowance Isolation * Advanced Stdcm Setup * set grid Margin After Before in stdcm Context * Fill with persisted Values * eslint and exhaustive deps * Correct optim error * après trad * conditionnal layout
alexandredamiron
added a commit
that referenced
this pull request
Jan 17, 2023
* prepare isolation * first Isolation Effort * Standard Allowance Isolation * Advanced Stdcm Setup * set grid Margin After Before in stdcm Context * prepare isolation * first Isolation Effort * Standard Allowance Isolation * Advanced Stdcm Setup * set grid Margin After Before in stdcm Context * Fill with persisted Values * eslint and exhaustive deps * Correct optim error * après trad * conditionnal layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, it may seem complicate for just two input in stdcm. But it also begins a isolation & composition of Allowance Component