Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:stdcm fix grid margins #2615

Merged
merged 1 commit into from
Dec 16, 2022
Merged

:stdcm fix grid margins #2615

merged 1 commit into from
Dec 16, 2022

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Dec 15, 2022

Fix #2465

@clarani clarani requested a review from a team December 15, 2022 17:48
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #2615 (f7a617d) into dev (3fc02cf) will increase coverage by 42.29%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##                dev    #2615       +/-   ##
=============================================
+ Coverage     38.11%   80.40%   +42.29%     
  Complexity     1679     1679               
=============================================
  Files           561      241      -320     
  Lines         17229     7662     -9567     
  Branches       2398      965     -1433     
=============================================
- Hits           6567     6161      -406     
+ Misses        10285     1155     -9130     
+ Partials        377      346       -31     
Flag Coverage Δ
core 83.68% <100.00%> (ø)
front ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain/java/fr/sncf/osrd/api/stdcm/STDCMEndpoint.java 79.71% <ø> (ø)
...main/java/fr/sncf/osrd/api/stdcm/STDCMRequest.java 100.00% <100.00%> (ø)
...r/sncf/osrd/api/stdcm/UnavailableSpaceBuilder.java 94.87% <100.00%> (ø)
front/src/main/Home/index.js
...rc/applications/editor/tools/switchEdition/tool.ts
...tions/editor/components/LinearMetadata/dataviz.tsx
...ents/Simulation/SpaceTimeChart/createChartDraft.ts
...ications/editor/tools/zoneSelection/components.tsx
front/src/applications/editor/data/utils.ts
front/src/common/InfraSelector/InfraSelector.js
... and 313 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eckter eckter merged commit 1b55134 into dev Dec 16, 2022
@eckter eckter deleted the cni/fix-grid-margins branch December 16, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stdcm - back: add grid margins before and after the trains
2 participants