-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdcm linear allowance #2645
Merged
Merged
stdcm linear allowance #2645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
fd7fe46
to
bbe92a1
Compare
Codecov Report
@@ Coverage Diff @@
## dev #2645 +/- ##
============================================
+ Coverage 38.05% 38.24% +0.18%
- Complexity 1678 1694 +16
============================================
Files 576 578 +2
Lines 17747 17803 +56
Branches 2446 2451 +5
============================================
+ Hits 6754 6809 +55
- Misses 10607 10608 +1
Partials 386 386
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bbe92a1
to
f741259
Compare
526f602
to
7f53e1f
Compare
7f53e1f
to
7371979
Compare
core: tests: stdcm: add simple standard allowance test
7371979
to
ab9cbb9
Compare
7d2186d
to
952677c
Compare
952677c
to
199d673
Compare
3 tasks
eckter
commented
Jan 10, 2023
flomonster
approved these changes
Jan 10, 2023
multun
approved these changes
Jan 10, 2023
axrolld
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds linear allowance in STDCM requests (back-end only).
We don't directly change the envelopes as we create them, because we need to keep track of the original envelope to properly compute the allowance and handle route transitions.
Instead, we keep track of the speed factor as a new field. We use it whenever we compute the time it takes to go from point A to B.