Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: first implementation e2E with smoke test select infra on grille horai… #2684

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

Math-R
Copy link
Contributor

@Math-R Math-R commented Dec 20, 2022

No description provided.

@Math-R Math-R requested a review from a team as a code owner December 20, 2022 19:05
@Math-R Math-R force-pushed the mrd/implement-e2e-framework branch 3 times, most recently from 665f426 to 9265ad7 Compare December 20, 2022 19:26
@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #2684 (4c60e3e) into dev (17f5e8f) will not change coverage.
The diff coverage is n/a.

❗ Current head 4c60e3e differs from pull request most recent head a90e220. Consider uploading reports for the commit a90e220 to get more accurate results

@@            Coverage Diff            @@
##                dev    #2684   +/-   ##
=========================================
  Coverage     38.31%   38.31%           
  Complexity     1713     1713           
=========================================
  Files           600      600           
  Lines         18335    18335           
  Branches       2513     2513           
=========================================
  Hits           7025     7025           
  Misses        10904    10904           
  Partials        406      406           
Flag Coverage Δ
front 4.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/Itinerary/DisplayItinerary/DisplayItinerary.tsx 0.00% <ø> (ø)
...plications/osrd/views/OSRDConfig/AddTrainLabels.js 0.00% <ø> (ø)
...ications/osrd/views/OSRDConfig/AddTrainSchedule.js 0.00% <ø> (ø)
...rc/applications/osrd/views/OSRDConfig/Itinerary.js 0.00% <ø> (ø)
...ont/src/applications/osrd/views/OSRDConfig/Map.tsx 0.00% <ø> (ø)
...s/osrd/views/OSRDConfig/SpeedLimitByTagSelector.js 0.00% <ø> (ø)
...cations/osrd/views/OSRDConfig/TimetableSelector.js 0.00% <ø> (ø)
front/src/common/InfraSelector/InfraSelector.js 0.00% <ø> (ø)
...on/InfraSelector/InfraSelectorModalBodyStandard.js 0.00% <ø> (ø)
...ommon/RollingStockSelector/RollingStockSelector.js 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Math-R Math-R force-pushed the mrd/implement-e2e-framework branch from 9265ad7 to 8f58680 Compare January 16, 2023 09:59
@Math-R Math-R force-pushed the mrd/implement-e2e-framework branch 11 times, most recently from d60420d to 2b7fbbe Compare January 16, 2023 16:58
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things must be done before merging:

  • Remove deadcode such as configuration example (I think it was auto generated)
  • Reduce timeouts (we shouldn't wait 30s for a test to complete)
  • Rebase and fix the failing test

@Math-R Math-R force-pushed the mrd/implement-e2e-framework branch 2 times, most recently from 487bef6 to 9b45328 Compare January 19, 2023 13:45
@Math-R Math-R force-pushed the mrd/implement-e2e-framework branch 5 times, most recently from 052cd59 to 4c60e3e Compare January 19, 2023 16:37
@flomonster flomonster force-pushed the mrd/implement-e2e-framework branch from 4c60e3e to a90e220 Compare January 19, 2023 16:51
@nicolaswurtz nicolaswurtz merged commit a7d813b into dev Jan 19, 2023
@nicolaswurtz nicolaswurtz deleted the mrd/implement-e2e-framework branch January 19, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants