Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editoast : add created and update column to an infra #2695

Merged
merged 1 commit into from
Jan 3, 2023
Merged

editoast : add created and update column to an infra #2695

merged 1 commit into from
Jan 3, 2023

Conversation

younesschrifi
Copy link
Contributor

@younesschrifi younesschrifi commented Dec 21, 2022 •
edited
Loading

Close #2666

@younesschrifi younesschrifi changed the title editoas : add created and modified column to an infra editoast : add created and modified column to an infra Dec 21, 2022
@younesschrifi younesschrifi force-pushed the yci/add-datetime-metadata branch 7 times, most recently from 0292f17 to 159beed Compare December 22, 2022 07:54
@younesschrifi younesschrifi changed the title editoast : add created and modified column to an infra editoast : add created and update column to an infra Dec 22, 2022
@younesschrifi younesschrifi force-pushed the yci/add-datetime-metadata branch 6 times, most recently from 0f109c4 to f4bd4ba Compare December 22, 2022 14:34
@codecov
Copy link

codecov bot commented Dec 22, 2022 •
edited
Loading

Codecov Report

Merging #2695 (ae3031a) into dev (50b176e) will increase coverage by 0.01%.
The diff coverage is 60.00%.

@@             Coverage Diff              @@
##                dev    #2695      +/-   ##
============================================
+ Coverage     37.81%   37.82%   +0.01%     
  Complexity     1679     1679              
============================================
  Files           575      575              
  Lines         17695    17703       +8     
  Branches       2449     2449              
============================================
+ Hits           6692     6697       +5     
- Misses        10617    10620       +3     
  Partials        386      386
Flag Coverage Δ
editoast 71.98% <60.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
editoast/src/infra.rs 66.66% <50.00%> (ø)
editoast/src/main.rs 31.39% <100.00%> (+0.80%) ⬆️
editoast/src/views/infra/edition.rs 92.30% <100.00%> (+0.64%) ⬆️
editoast/src/generated_data/utils.rs 78.94% <0.00%> (-5.27%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@younesschrifi younesschrifi marked this pull request as ready for review December 29, 2022 15:28
@younesschrifi younesschrifi requested a review from a team as a code owner December 29, 2022 15:28
flomonster
flomonster requested changes Dec 30, 2022
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great pr thanks.

@younesschrifi younesschrifi force-pushed the yci/add-datetime-metadata branch 3 times, most recently from 3d72e34 to 4541f05 Compare January 1, 2023 11:39
flomonster
flomonster previously approved these changes Jan 2, 2023
View reviewed changes
@younesschrifi younesschrifi force-pushed the yci/add-datetime-metadata branch from 4541f05 to cb8a688 Compare January 2, 2023 16:10
@younesschrifi younesschrifi force-pushed the yci/add-datetime-metadata branch from cb8a688 to ae3031a Compare January 2, 2023 21:30
@younesschrifi younesschrifi enabled auto-merge (rebase) January 3, 2023 08:56
@flomonster flomonster disabled auto-merge January 3, 2023 09:00
@flomonster flomonster merged commit e5e0045 into dev Jan 3, 2023
@flomonster flomonster deleted the yci/add-datetime-metadata branch January 3, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flomonster flomonster flomonster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add infra creation and update metadata
2 participants
@younesschrifi @flomonster