Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: Display errors and warnings as a table in the editor #2783

Merged
merged 5 commits into from
Jan 9, 2023

Conversation

sim51
Copy link
Contributor

@sim51 sim51 commented Jan 6, 2023

See ticket #2746

What can be improve in the futur :

  • select box level and type error should be linked ( I assuming that a type error is associated with a level)
  • actions on error, for now there is just "Select it on the map", but I'm sure we will have many.
  • adding a "fix action" that is related to the error type. Examples :
    ** empty_object => purpose "delete the object"
    ** out_of_range => purpose "edit the object"
    ** ...

BTW, the translation should be reviewed : https://github.com/DGEXSolutions/osrd/blob/bsi/editor-errors/front/public/locales/fr/translation.json#L88-L104

@sim51 sim51 requested a review from a team as a code owner January 6, 2023 12:28
@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #2783 (0ad58f7) into dev (206e37c) will decrease coverage by 0.15%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #2783      +/-   ##
============================================
- Coverage     38.07%   37.91%   -0.16%     
  Complexity     1679     1679              
============================================
  Files           576      581       +5     
  Lines         17744    17818      +74     
  Branches       2446     2452       +6     
============================================
  Hits           6756     6756              
- Misses        10603    10677      +74     
  Partials        385      385              
Flag Coverage Δ
front 4.08% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
front/src/applications/editor/Map.tsx 0.00% <ø> (ø)
...src/applications/editor/components/EntitySumUp.tsx 0.00% <0.00%> (ø)
...tions/editor/components/InfraErrors/InfraError.tsx 0.00% <0.00%> (ø)
.../editor/components/InfraErrors/InfraErrorsList.tsx 0.00% <0.00%> (ø)
...editor/components/InfraErrors/InfraErrorsModal.tsx 0.00% <0.00%> (ø)
...pplications/editor/components/InfraErrors/types.ts 0.00% <0.00%> (ø)
...s/editor/components/InfraErrors/useInfraErrors.tsx 0.00% <0.00%> (ø)
front/src/applications/editor/components/Modal.tsx 0.00% <ø> (ø)
front/src/applications/editor/data/api.ts 0.00% <0.00%> (ø)
front/src/applications/editor/nav.ts 0.00% <0.00%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jacomyal jacomyal merged commit 54acdf5 into dev Jan 9, 2023
@jacomyal jacomyal deleted the bsi/editor-errors branch January 9, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants