Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: base modal using context #2870

Merged
merged 1 commit into from
Jan 17, 2023
Merged

front: base modal using context #2870

merged 1 commit into from
Jan 17, 2023

Conversation

Math-R
Copy link
Contributor

@Math-R Math-R commented Jan 12, 2023

No description provided.

@Math-R Math-R requested a review from a team as a code owner January 12, 2023 16:34
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #2870 (6f429f0) into dev (cc0fd94) will decrease coverage by 0.36%.
The diff coverage is 0.00%.

❗ Current head 6f429f0 differs from pull request most recent head 9b7fb1b. Consider uploading reports for the commit 9b7fb1b to get more accurate results

@@             Coverage Diff              @@
##                dev    #2870      +/-   ##
============================================
- Coverage     38.26%   37.90%   -0.36%     
+ Complexity     1713     1699      -14     
============================================
  Files           594      586       -8     
  Lines         18126    18009     -117     
  Branches       2508     2480      -28     
============================================
- Hits           6936     6827     -109     
  Misses        10784    10784              
+ Partials        406      398       -8     
Flag Coverage Δ
front 4.10% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onents/TimetableSelector/TimetableSelectorModal.js 0.00% <0.00%> (ø)
...cations/osrd/views/OSRDConfig/TimetableSelector.js 0.00% <0.00%> (ø)
...rc/common/BootstrapSNCF/ModalSNCF/ModalProvider.js 0.00% <0.00%> (ø)
front/src/main/App/index.js 0.00% <ø> (ø)
...ditoast/src/generated_data/error/speed_sections.rs 79.16% <0.00%> (-16.67%) ⬇️
...src/main/java/fr/sncf/osrd/train/RollingStock.java 80.00% <0.00%> (-13.45%) ⬇️
...llowances/utils/AllowanceConvergenceException.java 66.66% <0.00%> (-13.34%) ⬇️
...cf/osrd/railjson/parser/RJSRollingStockParser.java 26.82% <0.00%> (-9.76%) ⬇️
editoast/src/generated_data/error/mod.rs 70.58% <0.00%> (-9.42%) ⬇️
editoast/src/generated_data/lpv_panel.rs 76.19% <0.00%> (-8.81%) ⬇️
... and 60 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nicolaswurtz nicolaswurtz merged commit 3bced78 into dev Jan 17, 2023
@nicolaswurtz nicolaswurtz deleted the mrd/base-modal branch January 17, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interaction with main container is blocked after leaving a page with the Rolling stock modal opened
2 participants