Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vcs/expose front version #3080

Merged
merged 3 commits into from
Feb 2, 2023
Merged

Vcs/expose front version #3080

merged 3 commits into from
Feb 2, 2023

Conversation

anisometropie
Copy link
Contributor

@anisometropie anisometropie commented Feb 2, 2023

closes #3064

@anisometropie anisometropie requested a review from a team as a code owner February 2, 2023 13:18
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #3080 (f37f58a) into dev (f7c190d) will increase coverage by 0.04%.
The diff coverage is 44.44%.

@@             Coverage Diff              @@
##                dev    #3080      +/-   ##
============================================
+ Coverage     38.67%   38.71%   +0.04%     
  Complexity     1708     1708              
============================================
  Files           605      605              
  Lines         18770    18760      -10     
  Branches       2516     2515       -1     
============================================
+ Hits           7259     7263       +4     
+ Misses        11102    11089      -13     
+ Partials        409      408       -1     
Flag Coverage Δ
front 4.80% <44.44%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...common/ReleaseInformations/ReleaseInformations.tsx 0.00% <0.00%> (ø)
front/src/common/api/emptyApi.ts 57.14% <ø> (ø)
front/src/reducers/index.ts 100.00% <ø> (ø)
front/src/Store.ts 100.00% <100.00%> (+14.28%) ⬆️
...on/InfraSelector/InfraSelectorModalBodyStandard.js 0.00% <0.00%> (ø)
front/src/common/api/osrdEditoastApi.ts 7.69% <0.00%> (+7.69%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

flomonster
flomonster previously approved these changes Feb 2, 2023
bloussou
bloussou previously approved these changes Feb 2, 2023
Copy link
Contributor

@bloussou bloussou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉 !!!

@anisometropie anisometropie dismissed stale reviews from bloussou and flomonster via bbafdd0 February 2, 2023 14:03
@anisometropie anisometropie force-pushed the vcs/expose-front-version branch from bbafdd0 to 77676d7 Compare February 2, 2023 14:18
@anisometropie anisometropie force-pushed the vcs/expose-front-version branch from 77676d7 to f37f58a Compare February 2, 2023 14:19
@anisometropie anisometropie merged commit 3edde75 into dev Feb 2, 2023
@anisometropie anisometropie deleted the vcs/expose-front-version branch February 2, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add front version in front service versions
4 participants