Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cni: front: GET/GEV get coordinated cursors #3134

Merged
merged 5 commits into from
Feb 17, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Feb 9, 2023

closes #3099
Reviewing commit by commit may make the review easier.

Fix bug : the cursors are not coordinated between GET and GEV
Capture vidéo du 2023-02-16 10-26-39.webm

Fix bug : the cursor on GEV keeps disappering when we stop moving the mouse
Capture vidéo du 2023-02-16 10-30-20.webm

Fix bug : when we select the train on the left side of the scenario, the GET is not updated
Capture vidéo du 2023-02-16 10-32-36.webm

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #3134 (61bb97c) into dev (b8fcd21) will decrease coverage by 0.28%.
The diff coverage is 0.00%.

❗ Current head 61bb97c differs from pull request most recent head 0f1d81b. Consider uploading reports for the commit 0f1d81b to get more accurate results

@@             Coverage Diff              @@
##                dev    #3134      +/-   ##
============================================
- Coverage     40.55%   40.27%   -0.28%     
+ Complexity     1711     1709       -2     
============================================
  Files           630      630              
  Lines         18766    18784      +18     
  Branches       2352     2349       -3     
============================================
- Hits           7610     7565      -45     
- Misses        10742    10816      +74     
+ Partials        414      403      -11     
Flag Coverage Δ
front 4.75% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nts/SimulationResults/ChartHelpers/ChartHelpers.ts 8.94% <0.00%> (ø)
...ulationResults/ChartHelpers/enableInteractivity.js 0.00% <0.00%> (ø)
...ies/components/SimulationResults/SpaceTimeChart.js 0.00% <ø> (ø)
...SimulationResults/SpaceTimeChart/SpaceTimeChart.js 0.00% <0.00%> (ø)
...ts/SimulationResults/SpaceTimeChart/createChart.ts 0.00% <0.00%> (ø)
...ents/SimulationResults/SpaceTimeChart/d3Helpers.js 0.00% <0.00%> (ø)
...ents/SimulationResults/SpaceTimeChart/drawTrain.js 0.00% <ø> (ø)
...s/SimulationResults/SpaceTimeChart/withOSRDData.js 0.00% <0.00%> (ø)
...mulationResults/SpeedSpaceChart/SpeedSpaceChart.js 0.00% <0.00%> (ø)
front/src/reducers/osrdsimulation/selectors.ts 0.00% <0.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@clarani clarani force-pushed the cni/front/get-coordinate-cursors branch from 673def5 to b6ce542 Compare February 9, 2023 13:26
@clarani clarani marked this pull request as ready for review February 9, 2023 13:28
@clarani clarani requested a review from a team as a code owner February 9, 2023 13:28
@clarani clarani force-pushed the cni/front/get-coordinate-cursors branch 5 times, most recently from 66020f3 to 7f57f0d Compare February 10, 2023 16:50
@alexandredamiron
Copy link
Contributor

On storybook, updatePointer is not applied (plain circle along the vertical line)
AND GEV starts empty need to use the reset button
Capture d’écran 2023-02-13 à 09 08 46

Capture d’écran 2023-02-13 à 09 07 19

anisometropie
anisometropie previously approved these changes Feb 17, 2023
@clarani clarani enabled auto-merge (rebase) February 17, 2023 10:51
@clarani clarani merged commit 3dff520 into dev Feb 17, 2023
@clarani clarani deleted the cni/front/get-coordinate-cursors branch February 17, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Front: Errors in cursor position between components (GET/GEV/etc.)
3 participants