Add derive for EditoastError 🚀

[flomonster]

Description

Add a fancy macro to avoid implementing the trait EditoastError by hand.

Before

use crate::error::EditoastError;

impl EditoastError for ElectricalProfilesError {
    fn get_status(&self) -> StatusCode {
        match self {
            Self::NotFound(_) => StatusCode::NOT_FOUND,
            Self::InternalError(_) => StatusCode::INTERNAL_SERVER_ERROR,
        }
    }

    fn get_type(&self) -> &'static str {
        match self {
            Self::NotFound(_) => "editoast:electrical_profiles:NotFound",
            Self::InternalError(_) => "editoast:electrical_profiles:InternalError",
        }
    }

    fn context(&self) -> Map<String, JsonValue> {
        match self {
            ElectricalProfilesError::NotFound(electrical_profile_set_id) => json!({
                "electrical_profile_set_id": electrical_profile_set_id,
            })
            .as_object()
            .cloned()
            .unwrap(),
            _ => Default::default(),
        }
    }
}

Now

use editoast_derive::EditoastError;

#[derive(Debug, Error, EditoastError)]
#[editoast_error(base_id = "electrical_profiles", context = "Self::context")]
pub enum ElectricalProfilesError {
    /// Couldn't found the infra with the given id
    #[error("Electrical Profile Set '{0}', could not be found")]
    #[editoast_error(status = 404)]
    NotFound(i64),
    #[error("An internal error occurred: '{}'", .0.to_string())]
    #[editoast_error(status = 500)]
    InternalError(String),
}

impl ElectricalProfilesError {
    fn context(&self) -> Map<String, JsonValue> {
        match self {
            ElectricalProfilesError::NotFound(electrical_profile_set_id) => json!({
                "electrical_profile_set_id": electrical_profile_set_id,
            })
            .as_object()
            .cloned()
            .unwrap(),
            _ => Default::default(),
        }
    }
}

[codecov]

Codecov Report

Merging #3148 (c9d4087) into dev (e5a4e52) will decrease coverage by 0.05%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##                dev    #3148      +/-   ##
============================================
- Coverage     40.82%   40.77%   -0.05%     
  Complexity     1709     1709              
============================================
  Files           624      624              
  Lines         18608    18549      -59     
  Branches       2314     2314              
============================================
- Hits           7597     7564      -33     
+ Misses        10608    10582      -26     
  Partials        403      403              

Flag	Coverage Δ
editoast	71.30% <50.00%> (+0.31%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
editoast/src/infra.rs	67.39% <ø> (-0.70%)	⬇️
editoast/src/schema/operation/mod.rs	45.45% <ø> (-6.93%)	⬇️
editoast/src/views/electrical_profiles.rs	88.09% <ø> (+2.09%)	⬆️
editoast/src/views/infra/edition.rs	90.32% <0.00%> (+10.32%)	⬆️
editoast/src/views/infra/errors.rs	77.55% <ø> (+3.04%)	⬆️
editoast/src/views/infra/objects.rs	100.00% <ø> (ø)
editoast/src/views/infra/pathfinding.rs	75.96% <ø> (+4.14%)	⬆️
editoast/src/views/infra/railjson.rs	84.61% <ø> (+6.04%)	⬆️
editoast/src/views/layers/mod.rs	35.59% <ø> (-3.47%)	⬇️
editoast/src/views/pagination.rs	100.00% <ø> (+28.57%)	⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[bloussou]

Clean !! It is great when lines are removed 🧹

[leovalais]

So nice! More macros! 🥳🥳🥳