Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: linter - limit number of warnings #3328

Merged
merged 1 commit into from
Feb 28, 2023
Merged

front: linter - limit number of warnings #3328

merged 1 commit into from
Feb 28, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Feb 23, 2023 •
edited
Loading

Closes #3311

@clarani clarani force-pushed the cni/front/linter-max-error-limit branch 3 times, most recently from c26f999 to 9b2a8aa Compare February 23, 2023 16:27
@codecov
Copy link

codecov bot commented Feb 23, 2023 •
edited
Loading

Codecov Report

Merging #3328 (3cdbbb8) into dev (d050e82) will increase coverage by 0.00%.
The diff coverage is 93.61%.

@@            Coverage Diff            @@
##                dev    #3328   +/-   ##
=========================================
  Coverage     66.87%   66.87%           
  Complexity     1876     1876           
=========================================
  Files           396      396           
  Lines         19106    19107    +1     
  Branches       1488     1488           
=========================================
+ Hits          12777    12778    +1     
  Misses         5653     5653           
  Partials        676      676
Flag Coverage Δ
front 52.36% <93.61%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nts/SimulationResults/ChartHelpers/ChartHelpers.ts 24.18% <0.00%> (ø)
...ront/src/applications/operationalStudies/consts.ts 68.65% <0.00%> (ø)
front/src/common/api/osrdEditoastApi.ts 91.41% <97.61%> (+0.01%) ⬆️
front/src/applications/editor/tools/types.ts 99.45% <100.00%> (ø)
front/src/common/Map/Consts/SignalsNames.ts 98.80% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

multun
multun reviewed Feb 23, 2023
View reviewed changes
@clarani clarani force-pushed the cni/front/linter-max-error-limit branch from 9b2a8aa to c49bc27 Compare February 24, 2023 09:06
Uriel-Sautron
Uriel-Sautron previously approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good !!

@clarani clarani marked this pull request as ready for review February 24, 2023 09:32
@clarani clarani requested review from a team and flomonster as code owners February 24, 2023 09:32
@clarani clarani force-pushed the cni/front/linter-max-error-limit branch 2 times, most recently from 5592154 to 57da231 Compare February 27, 2023 16:04
@clarani clarani force-pushed the cni/front/linter-max-error-limit branch from 57da231 to 3cdbbb8 Compare February 27, 2023 16:07
@anisometropie anisometropie mentioned this pull request Feb 27, 2023
Closed
@multun multun merged commit 5d1b718 into dev Feb 28, 2023
@multun multun deleted the cni/front/linter-max-error-limit branch February 28, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandredamiron alexandredamiron alexandredamiron left review comments

@multun multun multun approved these changes

@anisometropie anisometropie anisometropie approved these changes

@Uriel-Sautron Uriel-Sautron Uriel-Sautron left review comments

@flomonster flomonster Awaiting requested review from flomonster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement a warnings limiter
5 participants
@clarani @alexandredamiron @multun @anisometropie @Uriel-Sautron