Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: tests: fix RTK config and add integration test #3462

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Conversation

bloussou
Copy link
Contributor

@bloussou bloussou commented Mar 9, 2023

This PR is fixing RTK config and adding a test to ensure that openapi.yml files and middleware files are synchronized.

Two commits to show that the test is working

close #3460

@bloussou bloussou added the area:front Work on Standard OSRD Interface modules label Mar 9, 2023
@bloussou bloussou requested review from eckter and a team as code owners March 9, 2023 11:49
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #3462 (544bcba) into dev (bb239c2) will increase coverage by 0.17%.
The diff coverage is 95.96%.

@@             Coverage Diff              @@
##                dev    #3462      +/-   ##
============================================
+ Coverage     67.73%   67.90%   +0.17%     
  Complexity     1880     1880              
============================================
  Files           404      404              
  Lines         19940    20059     +119     
  Branches       1501     1501              
============================================
+ Hits          13506    13621     +115     
- Misses         5750     5754       +4     
  Partials        684      684              
Flag Coverage Δ
front 55.67% <95.96%> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
front/src/common/api/osrdEditoastApi.ts 93.14% <95.49%> (+0.59%) ⬆️
front/src/common/api/osrdMiddlewareApi.ts 91.49% <100.00%> (+0.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@eckter eckter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only reviewed the test, which I can't even review that much because I don't know how the front handles this

@bloussou bloussou enabled auto-merge (squash) March 9, 2023 13:42
@bloussou bloussou disabled auto-merge March 9, 2023 13:42
@bloussou bloussou merged commit 420df94 into dev Mar 9, 2023
@bloussou bloussou deleted the brieuc/RTKTest branch March 9, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
4 participants