Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: refacto search station #3516

Merged
merged 5 commits into from
Mar 22, 2023
Merged

Conversation

Uriel-Sautron
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron commented Mar 13, 2023

@Uriel-Sautron Uriel-Sautron requested a review from a team as a code owner March 13, 2023 14:43
@Uriel-Sautron Uriel-Sautron added the area:front Work on Standard OSRD Interface modules label Mar 13, 2023
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #3516 (8a0c453) into dev (de31346) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev    #3516   +/-   ##
=========================================
  Coverage     68.37%   68.37%           
  Complexity     1906     1906           
=========================================
  Files           421      421           
  Lines         21221    21221           
  Branches       1540     1540           
=========================================
  Hits          14509    14509           
  Misses         5994     5994           
  Partials        718      718           
Flag Coverage Δ
front 56.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Uriel-Sautron Uriel-Sautron force-pushed the usn/refacto-search-opertionnal-point branch 3 times, most recently from 9be3348 to ed88b34 Compare March 16, 2023 15:45
@Uriel-Sautron Uriel-Sautron force-pushed the usn/refacto-search-opertionnal-point branch from ed88b34 to 08603d6 Compare March 17, 2023 15:04
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there ! In clearSearchResult, can you also reset the 3 results (using resetSearchResult) ?

@Uriel-Sautron Uriel-Sautron force-pushed the usn/refacto-search-opertionnal-point branch 2 times, most recently from d3eab7f to 82b6f9a Compare March 21, 2023 14:28
clarani
clarani previously approved these changes Mar 21, 2023
@Uriel-Sautron Uriel-Sautron force-pushed the usn/refacto-search-opertionnal-point branch 3 times, most recently from 0586bbb to cc1a298 Compare March 21, 2023 14:54
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last (final) comment ^^

@Uriel-Sautron Uriel-Sautron force-pushed the usn/refacto-search-opertionnal-point branch from cc1a298 to 8a0c453 Compare March 22, 2023 08:53
@Uriel-Sautron Uriel-Sautron enabled auto-merge (squash) March 22, 2023 09:33
@Uriel-Sautron Uriel-Sautron merged commit f77533a into dev Mar 22, 2023
@Uriel-Sautron Uriel-Sautron deleted the usn/refacto-search-opertionnal-point branch March 22, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring of the search into OPs
4 participants