-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: refacto search station #3516
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #3516 +/- ##
=========================================
Coverage 68.37% 68.37%
Complexity 1906 1906
=========================================
Files 421 421
Lines 21221 21221
Branches 1540 1540
=========================================
Hits 14509 14509
Misses 5994 5994
Partials 718 718
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
9be3348
to
ed88b34
Compare
ed88b34
to
08603d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there ! In clearSearchResult, can you also reset the 3 results (using resetSearchResult) ?
…t trigram search and name search
…resent after four letters
d3eab7f
to
82b6f9a
Compare
0586bbb
to
cc1a298
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last (final) comment ^^
cc1a298
to
8a0c453
Compare
close Refactoring of the search into OPs #3524