-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: add signal support in the search engine #3527
Conversation
927367d
to
389ab7b
Compare
Codecov Report
@@ Coverage Diff @@
## dev #3527 +/- ##
============================================
+ Coverage 68.14% 68.20% +0.05%
Complexity 1919 1919
============================================
Files 424 424
Lines 21336 21404 +68
Branches 1557 1557
============================================
+ Hits 14540 14599 +59
- Misses 6063 6072 +9
Partials 733 733
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
5ecca50
to
01096ef
Compare
01096ef
to
6a1c97a
Compare
6a1c97a
to
cca1284
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty good PR 👍
8e27f01
to
b00aa59
Compare
dry
in endpoint payload to generate the SQL query without executing itsearch.yml
with a less hack-y deserializerlist
-- array constructorcontains
-- checks for array inclusionosrd_search_signal
signal
search object description insearch.yml
Both the old and incoming signaling models are supported, as the search engine provides the following criteria:
aspects
-- present in both signal descriptionslogical_types
-- only for the new signal descriptions, it's an empty array for the old onescloses #3546