-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: fix warnings & ts #3550
front: fix warnings & ts #3550
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #3550 +/- ##
============================================
+ Coverage 68.14% 68.32% +0.18%
Complexity 1919 1919
============================================
Files 424 424
Lines 21336 21493 +157
Branches 1557 1561 +4
============================================
+ Hits 14539 14685 +146
- Misses 6064 6071 +7
- Partials 733 737 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
c3d1a20
to
0f0f836
Compare
...rc/applications/operationalStudies/components/SimulationResults/SpaceTimeChart/drawTrain.jsx
Show resolved
Hide resolved
...rc/applications/operationalStudies/components/SimulationResults/ChartHelpers/ChartHelpers.ts
Outdated
Show resolved
Hide resolved
.../operationalStudies/components/SimulationResults/ChartHelpers/__tests__/ChartHelpers.spec.ts
Show resolved
Hide resolved
0f0f836
to
f5803d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, thanks ! I have tested it in my local env, everything is working 👍
front/src/applications/customget/components/SpaceTimeChart/drawTrain.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry, just a prettier warning to fix !
f5803d5
to
85f02ae
Compare
front: ts & warnings errors numbers 140 fixes f import warning fix import
85f02ae
to
9db24c3
Compare
#3265