Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix warnings & ts #3550

Merged
merged 2 commits into from
Mar 27, 2023
Merged

front: fix warnings & ts #3550

merged 2 commits into from
Mar 27, 2023

Conversation

anisometropie
Copy link
Contributor

@anisometropie anisometropie commented Mar 15, 2023

@anisometropie anisometropie requested a review from a team as a code owner March 15, 2023 10:29
@anisometropie anisometropie marked this pull request as draft March 15, 2023 10:30
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #3550 (9db24c3) into dev (c161593) will increase coverage by 0.18%.
The diff coverage is 61.36%.

@@             Coverage Diff              @@
##                dev    #3550      +/-   ##
============================================
+ Coverage     68.14%   68.32%   +0.18%     
  Complexity     1919     1919              
============================================
  Files           424      424              
  Lines         21336    21493     +157     
  Branches       1557     1561       +4     
============================================
+ Hits          14539    14685     +146     
- Misses         6064     6071       +7     
- Partials        733      737       +4     
Flag Coverage Δ
front 57.40% <61.36%> (+0.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
front/src/common/Pathfinding/Pathfinding.tsx 35.47% <0.00%> (+0.18%) ⬆️
front/src/config/config.ts 100.00% <ø> (ø)
front/src/reducers/osrdsimulation/actions.ts 24.56% <ø> (+0.53%) ⬆️
front/src/reducers/osrdsimulation/index.ts 49.19% <33.33%> (+1.19%) ⬆️
front/src/utils/strings.ts 40.00% <60.00%> (-12.64%) ⬇️
...nts/SimulationResults/ChartHelpers/ChartHelpers.ts 40.16% <73.33%> (+3.77%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nicolaswurtz nicolaswurtz added the area:front Work on Standard OSRD Interface modules label Mar 17, 2023
@anisometropie anisometropie force-pushed the vcs/ts-warnings branch 6 times, most recently from c3d1a20 to 0f0f836 Compare March 23, 2023 12:15
@anisometropie anisometropie marked this pull request as ready for review March 23, 2023 12:16
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thanks ! I have tested it in my local env, everything is working 👍

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, just a prettier warning to fix !

front: ts & warnings

errors numbers 140

fixes

f

import

warning

fix import
@anisometropie anisometropie enabled auto-merge (rebase) March 27, 2023 08:55
@anisometropie anisometropie merged commit c3fda3a into dev Mar 27, 2023
@anisometropie anisometropie deleted the vcs/ts-warnings branch March 27, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants