Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: tests: Isolate Railjson generator #3624

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

bloussou
Copy link
Contributor

@bloussou bloussou commented Mar 21, 2023

This PR is:

  • moving raijson-generator in its own package under the python/ folder
  • linting it with flake8, isort and black
  • making railjson-genrator a dependency of integration tests
  • making core use the moved library to generate its examples
  • updating script that loads small_infra and fast_rolling_stock

close #3188

@bloussou bloussou force-pushed the brieuc/MoveRAilJsonGeneratorToPythonFolder branch from 41eb8da to f7e946e Compare March 22, 2023 16:38
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #3624 (34561e9) into dev (ac44ab4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev    #3624   +/-   ##
=========================================
  Coverage     68.90%   68.90%           
  Complexity     2002     2002           
=========================================
  Files           439      439           
  Lines         22336    22336           
  Branches       1658     1658           
=========================================
  Hits          15391    15391           
  Misses         6150     6150           
  Partials        795      795           
Flag Coverage Δ
core 79.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bloussou bloussou force-pushed the brieuc/MoveRAilJsonGeneratorToPythonFolder branch 5 times, most recently from 7faa292 to 09fcb7d Compare March 28, 2023 09:41
@bloussou bloussou marked this pull request as ready for review March 28, 2023 14:39
@bloussou bloussou requested review from a team, eckter, flomonster and multun as code owners March 28, 2023 14:39
@bloussou bloussou changed the title core: Isolate Railjson generator core: tests: Isolate Railjson generator Mar 28, 2023
@bloussou bloussou added area:core Work on Core Service kind:enabler-task Enabler Story kind:tests Writing unit / e2e and integration tests labels Mar 29, 2023
@bloussou bloussou force-pushed the brieuc/MoveRAilJsonGeneratorToPythonFolder branch 2 times, most recently from 7e1b148 to a3b9084 Compare March 30, 2023 13:06
eckter
eckter previously approved these changes Mar 30, 2023
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I have minor suggestions.

@bloussou bloussou force-pushed the brieuc/MoveRAilJsonGeneratorToPythonFolder branch from a3b9084 to e99e691 Compare March 30, 2023 14:31
@bloussou bloussou force-pushed the brieuc/MoveRAilJsonGeneratorToPythonFolder branch from e99e691 to 34561e9 Compare March 30, 2023 14:37
@bloussou bloussou requested review from flomonster and eckter March 30, 2023 14:52
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bloussou bloussou merged commit 8829ac7 into dev Apr 3, 2023
@bloussou bloussou deleted the brieuc/MoveRAilJsonGeneratorToPythonFolder branch April 3, 2023 09:50
multun pushed a commit that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service kind:enabler-task Enabler Story kind:tests Writing unit / e2e and integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Isolate infra generator
3 participants