Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: GET: fix vanishing trains when dragging GET chart in rotate mode #3627

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

Yohh
Copy link
Contributor

@Yohh Yohh commented Mar 21, 2023

close #3466

@Yohh Yohh requested a review from a team as a code owner March 21, 2023 14:10
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #3627 (534f7ae) into dev (de31346) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev    #3627   +/-   ##
=========================================
  Coverage     68.37%   68.37%           
  Complexity     1906     1906           
=========================================
  Files           421      421           
  Lines         21221    21221           
  Branches       1540     1540           
=========================================
  Hits          14509    14509           
  Misses         5994     5994           
  Partials        718      718           
Flag Coverage Δ
front 56.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job !

@Yohh Yohh merged commit 5f238be into dev Mar 21, 2023
@Yohh Yohh deleted the yoh/fixVanishingRotatedTrainsInGET branch March 21, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: GET: trains rects vanish when draging chart in rotate mode
2 participants