Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: envelope: add check for case where train can't start #3629

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Mar 21, 2023

Fixes #3628

@eckter eckter requested a review from a team as a code owner March 21, 2023 14:22
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #3629 (ef8132e) into dev (de31346) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##                dev    #3629   +/-   ##
=========================================
  Coverage     68.37%   68.37%           
- Complexity     1906     1908    +2     
=========================================
  Files           421      421           
  Lines         21221    21225    +4     
  Branches       1540     1542    +2     
=========================================
+ Hits          14509    14513    +4     
  Misses         5994     5994           
  Partials        718      718           
Flag Coverage Δ
core 79.18% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...osrd/envelope_sim/pipelines/MaxEffortEnvelope.java 98.24% <100.00%> (+0.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eckter eckter merged commit 223483d into dev Mar 23, 2023
@eckter eckter deleted the ech/debug-empty-part branch March 23, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: we try to build an empty part builder if the train can't (re)start
5 participants