Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: Migrate MapSearchStation from js to ts #3711

Merged
merged 3 commits into from
Apr 12, 2023
Merged

front: Migrate MapSearchStation from js to ts #3711

merged 3 commits into from
Apr 12, 2023

Conversation

Uriel-Sautron
Copy link
Contributor

close #3709

@Uriel-Sautron Uriel-Sautron requested a review from a team as a code owner March 28, 2023 14:23
@codecov
Copy link

codecov bot commented Mar 28, 2023 •
edited
Loading

Codecov Report

Merging #3711 (ac56b95) into dev (aa09b49) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                dev    #3711      +/-   ##
============================================
+ Coverage     69.59%   69.64%   +0.05%     
  Complexity     2027     2027              
============================================
  Files           439      439              
  Lines         22126    22160      +34     
  Branches       1670     1670              
============================================
+ Hits          15399    15434      +35     
+ Misses         5927     5926       -1     
  Partials        800      800
Flag Coverage Δ
editoast 73.93% <ø> (+0.02%) ⬆️
front 59.16% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
front/src/common/api/emptyApi.ts 75.67% <100.00%> (+2.14%) ⬆️
front/src/common/api/osrdEditoastApi.ts 91.25% <100.00%> (+0.21%) ⬆️
front/src/reducers/map/index.ts 49.53% <100.00%> (+0.15%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nicolaswurtz nicolaswurtz added the area:front Work on Standard OSRD Interface modules label Mar 31, 2023
@Uriel-Sautron Uriel-Sautron force-pushed the usn/refacto/MapSearchStation branch from 77137f8 to 5d88468 Compare April 7, 2023 10:39
@Uriel-Sautron Uriel-Sautron requested a review from a team as a code owner April 7, 2023 10:43
flomonster
flomonster previously approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The openapi LGTM.

@Uriel-Sautron Uriel-Sautron force-pushed the usn/refacto/MapSearchStation branch from 20b23b4 to f212f5d Compare April 7, 2023 14:04
@Uriel-Sautron Uriel-Sautron force-pushed the usn/refacto/MapSearchStation branch 2 times, most recently from 0af894f to 5d7b5c6 Compare April 7, 2023 14:24
flomonster
flomonster previously approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only checked the openapi part.

anisometropie
anisometropie requested changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@anisometropie anisometropie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the openapi definitions ! just a few more things concerning arrays

@Uriel-Sautron Uriel-Sautron force-pushed the usn/refacto/MapSearchStation branch from 5d7b5c6 to bb37c67 Compare April 12, 2023 12:17
@Uriel-Sautron Uriel-Sautron force-pushed the usn/refacto/MapSearchStation branch from bb37c67 to ac56b95 Compare April 12, 2023 14:26
@Uriel-Sautron Uriel-Sautron merged commit cdd561a into dev Apr 12, 2023
@Uriel-Sautron Uriel-Sautron deleted the usn/refacto/MapSearchStation branch April 12, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flomonster flomonster flomonster approved these changes

@anisometropie anisometropie anisometropie approved these changes

@alexandredamiron alexandredamiron Awaiting requested review from alexandredamiron

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate MapSearchStation from js to ts
5 participants
@Uriel-Sautron @alexandredamiron @flomonster @anisometropie @nicolaswurtz