core: fix checkstyle CI #3766
Merged
core: fix checkstyle CI #3766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flomonster
previously approved these changes
Mar 31, 2023
eckter
force-pushed
the
ech/fix-checkstyle-ci
branch
from
f5d424e to
e4c75a0
Compare
eckter
force-pushed
the
ech/fix-checkstyle-ci
branch
from
e4c75a0 to
af7eb4a
Compare
Note: this isn't the recommended way to do this, but I couldn't figure out how to make it work with the "proper" way to handle subprojects
eckter
force-pushed
the
ech/fix-checkstyle-ci
branch
from
af7eb4a to
64812dd
Compare
Codecov Report
@@ Coverage Diff @@
## dev #3766 +/- ##
=========================================
Coverage 69.73% 69.73%
Complexity 2036 2036
=========================================
Files 442 442
Lines 22567 22567
Branches 1681 1681
=========================================
Hits 15736 15736
Misses 6026 6026
Partials 805 805
Flags with carried forward coverage won't be shown. Click here to find out more.
|
multun
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkstyle/spotbugs config did not apply to subprojects, it missed a lot of errors.
This isn't the "good practice" way to share settings between subprojects (see this link), but I couldn't make it work with the proper method.
I also removed the need for docstrings for constructors, as most of the time it's just
/** Constructor */. But I didn't remove the ones that were already there.Actually still a work in progress, because it's a pain to make everything work properly