-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdcm waypoints and intermediate stops #3791
Conversation
548e568
to
278b12c
Compare
Codecov Report
@@ Coverage Diff @@
## dev #3791 +/- ##
============================================
+ Coverage 69.73% 69.82% +0.09%
- Complexity 2036 2073 +37
============================================
Files 442 443 +1
Lines 22567 22688 +121
Branches 1681 1706 +25
============================================
+ Hits 15736 15841 +105
- Misses 6026 6039 +13
- Partials 805 808 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
278b12c
to
e836f2a
Compare
c398f3c
to
5094b37
Compare
4cb506b
to
7b084ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API lgtm. I did some test and get a 500 running the stdcm
endpoint:
{
"type": "core:assert_error",
"assert_message": "Assertion failed",
"cause": "INTERNAL",
"message": "Assertion failed",
"stack_trace": [
"LoadedSignalingInfra.kt:169",
"LoadedSignalingInfra.kt:184",
"ScheduleMetadataExtractor.kt:45",
"StandaloneSim.java:61",
"STDCMEndpoint.java:226",
"STDCMEndpoint.java:114",
"FkRegex.java:153",
"FkRegex.java:217",
"FkChain.java:72",
"TkFork.java:98",
"TkFallback.java:84",
"TkFallback.java:66",
"TkWrap.java:58",
"TkSlf4j.java:110",
"BkBasic.java:123",
"BkBasic.java:99",
"BkSafe.java:46",
"BkWrap.java:51",
"BkParallel.java:81",
"ThreadPoolExecutor.java:1136",
"ThreadPoolExecutor.java:635",
"Thread.java:833"
],
"trace": []
}
core/src/main/java/fr/sncf/osrd/stdcm/graph/STDCMPostProcessing.java
Outdated
Show resolved
Hide resolved
72268dd
to
3ba2564
Compare
@flomonster the assert you had is unrelated. It's still around (#3746), but now it only happens when using routes that go from buffer stop to buffer stop, which should be very uncommon. |
3cb8b08
to
f133699
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I tested stdcm with stops everything seems to work.
f133699
to
a7a8faf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Untested, LGTM
This PR is a collection of small changes that make it possible to handle intermediate steps in STDCM.
Most of the diff is in the form of new tests.
This hasn't been tested on actual infras and with front-end integration yet. I do intend to test everything before it's merged.