-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: TrackSectionModel & crate geos #3836
Conversation
1f8f5bc
to
9779ca9
Compare
Codecov Report
@@ Coverage Diff @@
## dev #3836 +/- ##
============================================
- Coverage 69.81% 69.77% -0.05%
Complexity 2016 2016
============================================
Files 439 439
Lines 22001 22018 +17
Branches 1662 1662
============================================
+ Hits 15361 15362 +1
- Misses 5845 5861 +16
Partials 795 795
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
9779ca9
to
28ec5e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! I found an error using the get_pf
endpoint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The replacement of the LineString Enum is nice !
I have yet to test this
ab7ed11
to
a6f1f9c
Compare
a6f1f9c
to
ec17d7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Well done!
I've tested to retrieve and delete a path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked both GET and DELETE (while running with cargo), it works 👌
As part of the work to migrate /pathfinding endpoints to editoast.
Model
API. There is probably a smarter/more generic way to do this but that is subject for another PR.geos::geojson
which is a reexport of the crategeojson
.geos
that can perform some operations on geometries defined using geojson objects (among other things) that will prove useful when migrating the endpoint POST and PUT /pathfinding. It uses the same underlying GEOS C lib than Django's Postgis extension.